New issue
Advanced search Search tips

Issue 859738 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Check failed: delay.InMilliseconds() == 0 (-60316512 vs. 0)delay should not be negative

Project Member Reported by alancutter@chromium.org, Jul 3

Issue description

Chrome Version: r98e6b138001317bbcc548841f26bd3f084fd0196 (Mon Jul 2 03:31:19 2018 +0000)
OS: Windows 10

What steps will reproduce the problem?
(1) Open Chrome with asserts.
(2) Leave computer to sleep overnight.
(3) Wake up computer.

What is the expected result?

Chrome still running.

What happens instead?

[35732:21780:0703/112950.405:FATAL:incoming_task_queue.cc(48)] Check failed: delay.InMilliseconds() == 0 (-60316512 vs. 0)delay should not be negative
Backtrace:
        base::debug::StackTrace::StackTrace [0x00007FF83AD07804+36] (D:\chromium\src\base\debug\stack_trace_win.cc:286)
        logging::LogMessage::~LogMessage [0x00007FF83AD360DF+95] (D:\chromium\src\base\logging.cc:593)
        base::internal::IncomingTaskQueue::AddToIncomingQueue [0x00007FF83AD4B1F6+518] (D:\chromium\src\base\message_loop\incoming_task_queue.cc:74)
        base::internal::MessageLoopTaskRunner::PostDelayedTask [0x00007FF83AD540FC+364] (D:\chromium\src\base\message_loop\message_loop_task_runner.cc:31)
        ThreadProfiler::ScheduleNextPeriodicCollection [0x00007FF825F2BFFF+275] (D:\chromium\src\chrome\common\thread_profiler.cc:269)
        base::debug::TaskAnnotator::RunTask [0x00007FF83AD09218+376] (D:\chromium\src\base\debug\task_annotator.cc:101)
        base::internal::IncomingTaskQueue::RunTask [0x00007FF83AD4B9BE+126] (D:\chromium\src\base\message_loop\incoming_task_queue.cc:129)
        base::MessageLoop::RunTask [0x00007FF83AD501A9+665] (D:\chromium\src\base\message_loop\message_loop.cc:352)
        base::MessageLoop::DeferOrRunPendingTask [0x00007FF83AD508A7+183] (D:\chromium\src\base\message_loop\message_loop.cc:361)
        base::MessageLoop::DoWork [0x00007FF83AD50BAB+715] (D:\chromium\src\base\message_loop\message_loop.cc:419)
        base::MessagePumpForIO::DoRunLoop [0x00007FF83AD55825+165] (D:\chromium\src\base\message_loop\message_pump_win.cc:478)
        base::MessagePumpWin::Run [0x00007FF83AD546B8+104] (D:\chromium\src\base\message_loop\message_pump_win.cc:58)
        base::MessageLoop::Run [0x00007FF83AD4FB98+136] (D:\chromium\src\base\message_loop\message_loop.cc:305)
        base::RunLoop::Run [0x00007FF83AD9FDA9+249] (D:\chromium\src\base\run_loop.cc:105)
        base::Thread::Run [0x00007FF83ADF23B8+200] (D:\chromium\src\base\threading\thread.cc:255)
        content::BrowserProcessSubThread::IOThreadRun [0x00007FF822A8C725+37] (D:\chromium\src\content\browser\browser_process_sub_thread.cc:179)
        content::BrowserProcessSubThread::Run [0x00007FF822A8C6A1+215] (D:\chromium\src\content\browser\browser_process_sub_thread.cc:134)
        base::Thread::ThreadMain [0x00007FF83ADF29A0+720] (D:\chromium\src\base\threading\thread.cc:340)
        base::`anonymous namespace'::ThreadFunc [0x00007FF83ADED17C+204] (D:\chromium\src\base\threading\platform_thread_win.cc:94)
        BaseThreadInitThunk [0x00007FF86DA63034+20]
        RtlUserThreadStart [0x00007FF86DE51431+33]

[20952:32836:0703/112951.310:FATAL:incoming_task_queue.cc(48)] Check failed: delay.InMilliseconds() == 0 (-59736647 vs. 0)delay should not be negative
Backtrace:
        base::debug::StackTrace::StackTrace [0x00007FF83AD07804+36] (D:\chromium\src\base\debug\stack_trace_win.cc:286)
        logging::LogMessage::~LogMessage [0x00007FF83AD360DF+95] (D:\chromium\src\base\logging.cc:593)
        base::internal::IncomingTaskQueue::AddToIncomingQueue [0x00007FF83AD4B1F6+518] (D:\chromium\src\base\message_loop\incoming_task_queue.cc:74)
        base::internal::MessageLoopTaskRunner::PostDelayedTask [0x00007FF83AD540FC+364] (D:\chromium\src\base\message_loop\message_loop_task_runner.cc:31)
        ThreadProfiler::ScheduleNextPeriodicCollection [0x00007FF825F2BFFF+275] (D:\chromium\src\chrome\common\thread_profiler.cc:269)
        base::debug::TaskAnnotator::RunTask [0x00007FF83AD09218+376] (D:\chromium\src\base\debug\task_annotator.cc:101)
        base::internal::IncomingTaskQueue::RunTask [0x00007FF83AD4B9BE+126] (D:\chromium\src\base\message_loop\incoming_task_queue.cc:129)
        base::MessageLoop::RunTask [0x00007FF83AD501A9+665] (D:\chromium\src\base\message_loop\message_loop.cc:352)
        base::MessageLoop::DeferOrRunPendingTask [0x00007FF83AD508A7+183] (D:\chromium\src\base\message_loop\message_loop.cc:361)
        base::MessageLoop::DoWork [0x00007FF83AD50BAB+715] (D:\chromium\src\base\message_loop\message_loop.cc:419)
        base::MessagePumpForIO::DoRunLoop [0x00007FF83AD55825+165] (D:\chromium\src\base\message_loop\message_pump_win.cc:478)
        base::MessagePumpWin::Run [0x00007FF83AD546B8+104] (D:\chromium\src\base\message_loop\message_pump_win.cc:58)
        base::MessageLoop::Run [0x00007FF83AD4FB98+136] (D:\chromium\src\base\message_loop\message_loop.cc:305)
        base::RunLoop::Run [0x00007FF83AD9FDA9+249] (D:\chromium\src\base\run_loop.cc:105)
        base::Thread::Run [0x00007FF83ADF23B8+200] (D:\chromium\src\base\threading\thread.cc:255)
        base::Thread::ThreadMain [0x00007FF83ADF29A0+720] (D:\chromium\src\base\threading\thread.cc:340)
        base::`anonymous namespace'::ThreadFunc [0x00007FF83ADED17C+204] (D:\chromium\src\base\threading\platform_thread_win.cc:94)
        BaseThreadInitThunk [0x00007FF86DA63034+20]
        RtlUserThreadStart [0x00007FF86DE51431+33]



I'll leave Chrome running overnight again to see if it happens reliably.
 
Components: -Internals>TaskScheduler
Owner: wittman@chromium.org
Status: Assigned (was: Untriaged)
The bug is that GetTimeToNextCollection() can return a negative delay https://cs.chromium.org/chromium/src/chrome/common/thread_profiler.cc?l=273&rcl=e27679b15b4bf6837ed43675aab3dbbfe0761f9e
Cc: wittman@chromium.org
 Issue 859888  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64ab9843e3587eb6ca8a87d0d2bdef28db412060

commit 64ab9843e3587eb6ca8a87d0d2bdef28db412060
Author: Mike Wittman <wittman@chromium.org>
Date: Fri Jul 06 20:57:36 2018

[Thread profiler] Avoid posting delayed tasks with negative TimeDelta

Avoids DCHECK failures in cases where the computer is put to sleep for
an extended period.

Bug:  859738 
Change-Id: Ibab67689586eb9dbedb42c2393ed24d3b2bbb531
Reviewed-on: https://chromium-review.googlesource.com/1125337
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573067}
[modify] https://crrev.com/64ab9843e3587eb6ca8a87d0d2bdef28db412060/chrome/common/thread_profiler.cc
[modify] https://crrev.com/64ab9843e3587eb6ca8a87d0d2bdef28db412060/chrome/common/thread_profiler_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment