New issue
Advanced search Search tips

Issue 859729 link

Starred by 1 user
Status: Started
Owner:
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add content verification UMA

Project Member Reported by lazyboy@chromium.org, Jul 3 
Add some more UMA after content verification code was refactored.

For ContentVerifyJob, it would be nice to have detailed results, i.e. whether verification
  - succeeded
  - failed due to tampering
  - failed to to disk corruption: either because the content became garbage, or the file became unreadable
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588df565511a70bd5c5244e50e858f1bc0a495f1

commit 588df565511a70bd5c5244e50e858f1bc0a495f1
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Fri Jul 06 20:16:04 2018

Extensions: Add some content verification UMA.

For computed_hashes.json and verified_contents.json:
Time how long it takes of successfully reading the files and
serializing them. Also record how frequently serialization
fails.
ComputedHashesInitTime/ComputedHashesReadResult
VerifiedContentsInitTime/VerifiedContentsInitResult

Record if fetching verified_contents succeeds or fails.

And the most important one "ReadContentHashTime", would give a
high level overview of how much time we spend on just "getting the
stuff", discarding any oddities around file missing and such.

Bug: 859729
Change-Id: Iaef0d495a55bd910811b7cd3b8a560ed6b52c719
Reviewed-on: https://chromium-review.googlesource.com/1121382
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573054}
[modify] https://crrev.com/588df565511a70bd5c5244e50e858f1bc0a495f1/extensions/browser/computed_hashes.cc
[modify] https://crrev.com/588df565511a70bd5c5244e50e858f1bc0a495f1/extensions/browser/content_verifier.cc
[modify] https://crrev.com/588df565511a70bd5c5244e50e858f1bc0a495f1/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/588df565511a70bd5c5244e50e858f1bc0a495f1/extensions/browser/content_verifier/content_hash.h
[modify] https://crrev.com/588df565511a70bd5c5244e50e858f1bc0a495f1/extensions/browser/verified_contents.cc
[modify] https://crrev.com/588df565511a70bd5c5244e50e858f1bc0a495f1/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment