"TabTest.HitTestTopPixel" is flaky |
||
Issue description"TabTest.HitTestTopPixel" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIgsSBUZsYWtlIhdUYWJUZXN0LkhpdFRlc3RUb3BQaXhlbAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jul 3
On further checking, these are all tests from TabTest since that CL changed the base class it's very likely the culprit. Proceeding to revert it.
,
Jul 3
That CL was meant to prevent this precise problem, which would otherwise be caused by other Tab changes. The failure is saying a (non-Chrome) Views LayoutProvider has already been set up by the time someone is asking for the Chrome one. Reverting is likely to turn this confusing flakiness into a guaranteed failure on all bots.
,
Jul 3
,
Jul 3
right, I'll watch next few builds on dashboard and re-land if it gets worst. https://ci.chromium.org/p/chromium/g/chromium/console
,
Jul 3
pkasting@ noted that all reports from try-flakes are actually from his attempt on his CL which didn't have the proper dependency on other CLs. So, it's better to reland the original CL, proceeding to that.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef166a2cea68934ecfb9c66e15b77c1fce0d6279 commit ef166a2cea68934ecfb9c66e15b77c1fce0d6279 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Jul 03 01:58:06 2018 Reland "Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase." This reverts commit cf25f1427cb867f8b5de93ea54341abacc59ecdf. Reason for revert: crbug.com/859718 was a false alarm, failures was before merging the CL originally reverted. Original change's description: > Revert "Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase." > > This reverts commit ed47f31beff24c6610486dbc958948cee7a68fd3. > > Reason for revert: All tests from TabTest reported flaky crbug.com/859718 > > Original change's description: > > Convert chrome/ tests using ViewsTestBase to ChromeViewsTestBase. > > > > This ensures these tests are testing the actual harmony/refresh behavior, and > > makes sure as people add more calls to ChromeLayoutProvider to the code they > > don't result in unexpected test crashes. > > > > Bug: none > > Change-Id: If21b7eec387dc47be448e2dbb2730ddacb7b51fe > > Reviewed-on: https://chromium-review.googlesource.com/1121787 > > Commit-Queue: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#572008} > > TBR=pkasting@chromium.org,thestig@chromium.org > > Change-Id: Ib0d68d4aaff4a8617b95f4456eef0dad9f66e57b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Reviewed-on: https://chromium-review.googlesource.com/1123839 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572070} TBR=pkasting@chromium.org,thestig@chromium.org,lucmult@chromium.org Change-Id: I7c738232c08a506baa0ebf43d1a4df87fa2ca2f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859718 Reviewed-on: https://chromium-review.googlesource.com/1123859 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572082} [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/download/download_item_view_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view_layout_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/omnibox/omnibox_result_view_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/payments/validating_textfield_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/payments/view_stack_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/sync/bubble_sync_promo_view_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/browser/ui/views/tabs/tab_unittest.cc [modify] https://crrev.com/ef166a2cea68934ecfb9c66e15b77c1fce0d6279/chrome/test/views/accessibility_checker_unittest.cc
,
Jul 3
Reverted the revert: https://chromium-review.googlesource.com/c/chromium/src/+/1123859 Gerrit was smart enough to detect it as a "reland" of original. :-) Marking this as fixed and I'll report this situation to Try-Flakes team, since this seems a false positive that we can automatically detect.
,
Jul 3
Reported Try-Flakes issue: crbug.com/859763
,
Jul 3
Issue 859739 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by lucmult@chromium.org
, Jul 3