New issue
Advanced search Search tips

Issue 859715 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

browser_tests failing on chromium.chromiumos/linux-chromeos-dbg

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 2

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of spqchan@google.com

browser_tests failing on chromium.chromiumos/linux-chromeos-dbg

Builders failed on: 
- linux-chromeos-dbg: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg


 
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9be94722d52ede6477bc1c62c2b07fe59ea11bdc

commit 9be94722d52ede6477bc1c62c2b07fe59ea11bdc
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Jul 03 06:32:24 2018

Disable Flaky tests IncompliantPlatformDelayInstall

These 3 tests have been failing a lot, passing only 60% of time
according to findit-for-me.

Tbr: xiyuan@chromium.org
Bug:  859715 
Change-Id: I45f89d626cccad4d1aac55184e7aac11fc862bc9
Reviewed-on: https://chromium-review.googlesource.com/1124001
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572127}
[modify] https://crrev.com/9be94722d52ede6477bc1c62c2b07fe59ea11bdc/chrome/browser/chromeos/login/kiosk_browsertest.cc

Components: Tests>Flaky UI>Shell>Kiosk
Labels: OS-Chrome
From https://chromium-swarm.appspot.com/task?id=3e712dcc43aa5510&refresh=10&show_raw=1, where we expect to see 7 (SCREEN_GAIA_SIGNIN), but the actual screen is 9 (SCREEN_KIOSK_AUTOLAUNCH). That is the confirmation screen to allow auto launch. The test seems missing a KioskAppManager::Get()->SetEnableAutoLaunch(true) call when setting up auto launch.

../../chrome/browser/chromeos/login/test/oobe_screen_waiter.cc:25: Failure
Expected equality of these values:
  expected_screen_
    Which is: 4-byte object <07-00 00-00>
  GetOobeUI()->current_screen()
    Which is: 4-byte object <09-00 00-00>
Stack trace:
#0 0x000003f4b750 StackTraceGetter::CurrentStackTrace()
#1 0x000003f6c217 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#2 0x000003f6b67d testing::internal::AssertHelper::operator=()
#3 0x00000cc541a2 chromeos::OobeScreenWaiter::Wait()
#4 0x000002866ab3 chromeos::KioskTest::StartUIForAppLaunch()
#5 0x0000028584f4 chromeos::KioskUpdateTest_IncompliantPlatformDelayInstall_Test::RunTestOnMainThread()
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22b3b6f324ebd1a2ce250e5bf7fa647886a8b84

commit a22b3b6f324ebd1a2ce250e5bf7fa647886a8b84
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Fri Jul 27 00:08:26 2018

kiosk: Fix flaky IncompliantPlatformDelayInstall test

Add KioskAppManager::Get()->SetEnableAutoLaunch(true) when setting
up auto launch kiosk so that SCREEN_KIOSK_AUTOLAUNCH does not gets
into the way to break the test.

Bug:  859715 
Change-Id: I940ff9f275cc8a2d450e0338366f1702eb8277f0
Reviewed-on: https://chromium-review.googlesource.com/1148899
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578495}
[modify] https://crrev.com/a22b3b6f324ebd1a2ce250e5bf7fa647886a8b84/chrome/browser/chromeos/login/kiosk_browsertest.cc

Status: Fixed (was: Available)
KioskUpdateTest.IncompliantPlatformDelayInstall is green for the last 10 runs on linux-chromeos-dbg.

Sign in to add a comment