The GetComments RPC (or any better name you may find) will most likely use an Issue and a Project (monorail in this case) to return the list of all comments associated with that issue.
Following https://chromium-review.googlesource.com/c/infra/infra/+/972149
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/7c580d845bf5800f36cc81e15bd675e9d1c4cd95 commit 7c580d845bf5800f36cc81e15bd675e9d1c4cd95 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Jul 03 02:42:12 2018 monorail go lib: regenerate and fix with newest protobuf. R=vadimsh Bug: 859707 Change-Id: I224c3c33db9fb87c6e4db493ae76f8d55acc63be Reviewed-on: https://chromium-review.googlesource.com/1123769 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/7c580d845bf5800f36cc81e15bd675e9d1c4cd95/go/src/infra/appengine/sheriff-o-matic/som/handler/annotations.go [modify] https://crrev.com/7c580d845bf5800f36cc81e15bd675e9d1c4cd95/go/src/infra/monorail/endpoints_test.go [modify] https://crrev.com/7c580d845bf5800f36cc81e15bd675e9d1c4cd95/go/src/infra/monorail/monorail.pb.go [modify] https://crrev.com/7c580d845bf5800f36cc81e15bd675e9d1c4cd95/go/src/infra/monorail/validation_test.go [modify] https://crrev.com/7c580d845bf5800f36cc81e15bd675e9d1c4cd95/go/src/infra/monorail/ext_test.go [modify] https://crrev.com/7c580d845bf5800f36cc81e15bd675e9d1c4cd95/go/src/infra/monorail/endpoints.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d50f6ba0b8846b2c123e0b75d228f099f26f6919 commit d50f6ba0b8846b2c123e0b75d228f099f26f6919 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Jul 03 06:53:10 2018 monorail go API: add ListComments support. R=vadimsh Bug: 859707 Change-Id: I17f95b787a428d953bfe919c11796876272bc958 Reviewed-on: https://chromium-review.googlesource.com/1123881 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/monorailtest/server.go [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/appengine/cr-audit-commits/app/test_utils.go [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/endpoints.go [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/endpoints_test.go [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/monorail.pb.go [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/monorailtest/client.go [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/validation.go [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/monorail.infra_testing [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/monorail.proto [modify] https://crrev.com/d50f6ba0b8846b2c123e0b75d228f099f26f6919/go/src/infra/monorail/pb.discovery.go
This is ready to use.
Awesome! Thanks so much tandrii@. I really appreciate it!
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e1d034447b75eb260bdf35434f7b4695eccd3c4a commit e1d034447b75eb260bdf35434f7b4695eccd3c4a Author: Nodir Turakulov <nodir@google.com> Date: Tue Jul 24 18:21:48 2018 [monorail] Add Comment.updates field. R=vadimsh@chromium.org Also update tag of Update.labels to match https://chromium.googlesource.com/infra/infra/+/54cb1925180d0413f02e4948290ab51a7131b74e/appengine/monorail/proto/api_pb2_v1.py#125 Bug: 859707 Change-Id: I2a6544147218e74352cd65f38d54d3686b39a6f9 Reviewed-on: https://chromium-review.googlesource.com/1145585 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/e1d034447b75eb260bdf35434f7b4695eccd3c4a/go/src/infra/monorail/endpoints_test.go [modify] https://crrev.com/e1d034447b75eb260bdf35434f7b4695eccd3c4a/go/src/infra/monorail/monorail.pb.go [modify] https://crrev.com/e1d034447b75eb260bdf35434f7b4695eccd3c4a/go/src/infra/monorail/monorail.proto [modify] https://crrev.com/e1d034447b75eb260bdf35434f7b4695eccd3c4a/go/src/infra/monorail/pb.discovery.go
Comment 1 by tandrii@chromium.org
, Jul 2Status: Started (was: Assigned)