New issue
Advanced search Search tips

Issue 859706 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug
Proj-VR

Blocking:
issue 864810



Sign in to add a comment

[WebXR] XRDevice should not extend EventTarget

Project Member Reported by bajones@chromium.org, Jul 2

Issue description

Chrome's WebXR implementation currently has XRDevice extending EventTarget, which is not to spec. (It was the case in an older version of the spec, but has since been removed.) We should remove this inheritance in Chrome to ensure we match the spec.
 
Components: Blink>WebXR
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0

commit 0c6f1ba1efc8e439a0c4290bd83454d0427c27c0
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Jul 06 19:48:26 2018

XRDevice should not extend EventTarget.

The spec removed any events that were fired on the XRDevice a while ago,
but our implementation forgot to clean this up.

Bug:  859706 
Change-Id: I086813a5a2cbf6ebbf7faf576b066fa3957ad5dc
Reviewed-on: https://chromium-review.googlesource.com/1123645
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573048}
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/WebKit/LayoutTests/external/wpt/interfaces/webxr.idl
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/blink/renderer/core/html/canvas/canvas_context_creation_attributes_core.h
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/blink/renderer/modules/event_target_modules_names.json5
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/blink/renderer/modules/xr/xr_device.cc
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/blink/renderer/modules/xr/xr_device.h
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/blink/renderer/modules/xr/xr_device.idl
[modify] https://crrev.com/0c6f1ba1efc8e439a0c4290bd83454d0427c27c0/third_party/blink/renderer/modules/xr/xr_session.cc

Status: Fixed (was: Started)
Blocking: 864810

Sign in to add a comment