New issue
Advanced search Search tips

Issue 859698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Add metrics for bottom toolbar experiment

Project Member Reported by mdjones@chromium.org, Jul 2

Issue description

We need to set up metrics for the following:

- User actions for all of the bottom toolbar buttons.
- Histogram for how the omnibox was focused.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8ce3943ab0a699a9f94916de4bf06813f108c5

commit bb8ce3943ab0a699a9f94916de4bf06813f108c5
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Jul 10 15:14:48 2018

Add histogram for tracking omnibox focus reason

Track the reasons that the omnibox was focused for determining success
of the omnibox accelerator but is also generally useful for learning
how users use the omnibox. The fake omnibox that the NTP uses is
specifically differentiated because it is in a different location on
screen.

Bug:  859698 
Change-Id: Iaf4e85850c32cdd9b2cae510db8b75a3a790de23
Reviewed-on: https://chromium-review.googlesource.com/1123402
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573733}
[modify] https://crrev.com/bb8ce3943ab0a699a9f94916de4bf06813f108c5/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/bb8ce3943ab0a699a9f94916de4bf06813f108c5/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
[modify] https://crrev.com/bb8ce3943ab0a699a9f94916de4bf06813f108c5/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/bb8ce3943ab0a699a9f94916de4bf06813f108c5/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/bb8ce3943ab0a699a9f94916de4bf06813f108c5/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/221b5244d97477a1e12b8e63d7766af91e83db4b

commit 221b5244d97477a1e12b8e63d7766af91e83db4b
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Jul 10 17:40:03 2018

Add user action for omnibox accelerator tap

Bug:  859698 
Change-Id: I67f3758c310d62edc306a1e69de6fe747ce2ed7b
Reviewed-on: https://chromium-review.googlesource.com/1129963
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573795}
[modify] https://crrev.com/221b5244d97477a1e12b8e63d7766af91e83db4b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/221b5244d97477a1e12b8e63d7766af91e83db4b/tools/metrics/actions/actions.xml

Status: Fixed (was: Assigned)

Sign in to add a comment