Make Settings search work with Polymer 2. |
||
Issue descriptionThere are currently two issues making it not work. 1) The logic to force render a subpage relies on the <template> tag. Should be updated to use <dom-if> instead, see [1]. 2) Binding a no-search attribute, like is done at [2], does not work with <dom-if> element (throws a runtime error). [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search_settings.js?l=65-69 [2] https://cs.chromium.org/search/?q=%22no-search$%3D%22&type=cs
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e commit 121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e Author: dpapad <dpapad@chromium.org> Date: Tue Jul 10 23:00:29 2018 Settings: Make subpage no-search mechanism work in Polymer 2. In Polymer 2 the following pattern throws a runtime error: <template is="dom-if" no-search$="[[foo]]>...</template> This CL introduces a backward compatible solution such that the no-search mechanism works both in Polymer 1 and Polymer 2. Some cleanups can be done once migration has completed. Bug: 859689 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0732a8c6cd48b94ad3d81cc017fe59688fe3df13 Reviewed-on: https://chromium-review.googlesource.com/1123711 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573968} [modify] https://crrev.com/121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e/chrome/browser/resources/settings/device_page/device_page.html [modify] https://crrev.com/121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e/chrome/browser/resources/settings/search_settings.js [modify] https://crrev.com/121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e/chrome/test/data/webui/settings/search_settings_test.js
,
Jul 11
I believe this is fixed now. Will re-open if there are more tasks. |
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, Jul 2