New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[PIP] Update string capitalization

Project Member Reported by apaci...@chromium.org, Jul 2

Issue description

For usages of "Picture-in-Picture":

Mac should be "Picture in Picture"
Non-Mac should be "Picture-in-picture"

This is per email discussion with amyroberts and srihim.
 
Cc: fbeaufort@chromium.org mlamouri@chromium.org
+fbeaufort@ because he cares about the naming
Description: Show this description
It's true, I do care about the naming ;)

Safari uses both Picture in Picture and "Picture-in-Picture". See https://support.apple.com/en-us/ht206997
Vimeo on Safari uses "Picture-in-Picture".

Having two names of the same feature will make it harder for translators to get it right 100% time.

It is shortened as PiP not Pip.

I'd suggest having one consistent string "Picture-in-Picture" in Chrome.
fbeaufort -- I'm going to add you to the email thread to weigh in on this. :)
Labels: Target-69
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dff79111f3857be3ac9d61a2f3b1c1b95442a699

commit dff79111f3857be3ac9d61a2f3b1c1b95442a699
Author: Jennifer Apacible <apacible@chromium.org>
Date: Tue Jul 10 22:53:14 2018

[Picture in Picture] Update "Picture-in-Picture" strings per OS.

MacOS and other OS have slightly different formats, where:
- MacOS: "Picture in Picture"
- Non-MacOS: "Picture in picture"
- Instructional (non-menu/titles): "...picture-in-picture mode..."

Bug:  859670 
Change-Id: I424bb618b9b337bf944d2f082522b9539d25e43c
Reviewed-on: https://chromium-review.googlesource.com/1123321
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573963}
[modify] https://crrev.com/dff79111f3857be3ac9d61a2f3b1c1b95442a699/chrome/app/generated_resources.grd
[modify] https://crrev.com/dff79111f3857be3ac9d61a2f3b1c1b95442a699/content/app/strings/content_strings.grd
[modify] https://crrev.com/dff79111f3857be3ac9d61a2f3b1c1b95442a699/third_party/WebKit/LayoutTests/media/controls/video-controls-overflow-menu-text.html
[modify] https://crrev.com/dff79111f3857be3ac9d61a2f3b1c1b95442a699/third_party/WebKit/LayoutTests/media/overflow-menu.js

Status: Fixed (was: Started)

Sign in to add a comment