New issue
Advanced search Search tips

Issue 859666 link

Starred by 2 users
Status: Assigned
Owner:
billorr@chromium.org
Cc:
bsheedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

VR test - testFocusUpdatesSynchronously is failing

Project Member Reported by billorr@chromium.org, Jul 2 
The test validates that we remove intents synchronously when we lose focus.

This test regressed with a recent change to use mojo interfaces (and therefore introduced some asynchronous behavior).  The intent is also removed due to VrShellDelegate listening for Activity events.  The test should be updated to validate that the Activity events are sufficient/correct.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9109da6dc54fa0b4d2f94549ee96214b15955f77

commit 9109da6dc54fa0b4d2f94549ee96214b15955f77
Author: Bill Orr <billorr@chromium.org>
Date: Tue Jul 03 17:53:39 2018

Temporarily disable testFocusUpdatesSyncronously

The proper fix requires some design work.  The current behavior
does suffer from potential raciness, but shouldn't cause real-world
issues for users.

BUG=859666

Change-Id: I8d502a7db25949d2508675e1d153dbf56f69e1ed
Reviewed-on: https://chromium-review.googlesource.com/1124948
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572284}
[modify] https://crrev.com/9109da6dc54fa0b4d2f94549ee96214b15955f77/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java

Comment 2 by btebbs@chromium.org, Jul 4

Components: Internals>XR

Comment 3 by mthiesse@chromium.org, Jul 5 

As discussed offline, we should skip over device/ entirely for the listeningForActivate code, the device doesn't need to be aware of it.

Comment 4 by mthiesse@chromium.org, Jul 5

Labels: -Pri-3 Target-70 Pri-1
Upping priority - we shouldn't leave this test disabled for too long.

Comment 5 by efoo@chromium.org, Aug 7 

Removing Internals>VR component and assigning to Internals>XR

Comment 6 by efoo@chromium.org, Aug 7

Components: -Internals>VR
►

Sign in to add a comment