Issue metadata
Sign in to add a comment
|
(Accessibility) Make sure contrast of text in new UI changes meets GAR guidelines |
||||||||||||||||||||||||
Issue descriptionlpalmaro pointed out that the subtext in the UI redesign may be too light to meet GAR guidelines, making the gray to hard to see for people who are visually impaired. Can you check this and make any changes necessary to meet the minimum contrast ratio (4.5:1)? An incomplete list of where the light gray text appears (you may have to find it elsewhere in the app): -On the NTP titles of most visited and collections -On subtext of articles listed in the feed -In collections views like Bookmarks, on the subtext for each line item
,
Jul 3
,
Jul 10
,
Jul 18
An additional related note from a dogfooder: "The text on the welcome screen (where you can search google or open your recent websites) is a bit gray, making it feel like it blurry (but it's not) - even though it's even more loose (less packed..)."
,
Jul 25
Load-shedding to martijnb@. Martijn, can you turn this into a list of specific changes that need to be made?
,
Jul 25
Yep, I think the light gray appears in the list below. I'm leaving it up to Pete to decide which changes to do. * NTP - titles under most visited and collections Current Contrast: 2.96 - #969696 (Black 41%) Proposed Contrast: 4.54 - #767676 (Black 54%) * NTP Zine - subtext of articles listed in the feed Current Contrast: 2.85 - #999999 (Black 40%) Proposed Contrast: 4.54 - #767676 (Black 54%) * Collections (Bookmarks, Reading List, Recent Tabs, History) - Cell Subtext and Timestamp Current Contrast: 3.1 - #8E8E93 Proposed Contrast: 4.54 - #767676 * Promos (Collections, Zine, Settings) Current Contrast: 5.1 - #6D6D72 * Settings - Cell Subtext Current Contrast: 3.1 - #8E8E93 Proposed Contrast: 4.54 - #767676 * Tab Grid: (Recent Tabs) Current Contrast: 4.89 - #8F8E93 * Search Fields (History, etc) Current Contrast: 2.66 - #8D8D92 Proposed Contrast: 4.54 - #666666
,
Jul 25
lod@ -- Can you work with martijnb@ to get these colors updated.
,
Jul 25
In Pete's absence I'm going to implement all of these, rather err on the side of too readable than not enough. We can revert or make further updates later.
,
Jul 25
Sounds good. As discussed, don't implement changes for Search Fields.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7beedc820bff35f6f06074d8d9fb66b27f48ca02 commit 7beedc820bff35f6f06074d8d9fb66b27f48ca02 Author: Elodie Banel <lod@google.com> Date: Wed Jul 25 14:15:20 2018 Update colors to meet GAR guidelines. Darkening anything under a 4.5 contrast ratio. Bug: 859651 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b56ca36d89e6d62a9104aaddf14e12f7c4b8e0a Reviewed-on: https://chromium-review.googlesource.com/1150159 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#577874} [modify] https://crrev.com/7beedc820bff35f6f06074d8d9fb66b27f48ca02/ios/chrome/browser/ui/collection_view/cells/collection_view_cell_constants.h [modify] https://crrev.com/7beedc820bff35f6f06074d8d9fb66b27f48ca02/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm [modify] https://crrev.com/7beedc820bff35f6f06074d8d9fb66b27f48ca02/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_constants.mm
,
Jul 25
,
Jul 25
,
Jul 31
Please add merge request label if this needs to be merged to M69.
,
Aug 1
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85f0bb472446be45f444221e0f34392f3fda76ba commit 85f0bb472446be45f444221e0f34392f3fda76ba Author: Elodie Banel <lod@google.com> Date: Fri Aug 03 11:48:37 2018 Update colors to meet GAR guidelines. Darkening anything under a 4.5 contrast ratio. Bug: 859651 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b56ca36d89e6d62a9104aaddf14e12f7c4b8e0a Reviewed-on: https://chromium-review.googlesource.com/1150159 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577874}(cherry picked from commit 7beedc820bff35f6f06074d8d9fb66b27f48ca02) Reviewed-on: https://chromium-review.googlesource.com/1162121 Reviewed-by: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#377} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/85f0bb472446be45f444221e0f34392f3fda76ba/ios/chrome/browser/ui/collection_view/cells/collection_view_cell_constants.h [modify] https://crrev.com/85f0bb472446be45f444221e0f34392f3fda76ba/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm [modify] https://crrev.com/85f0bb472446be45f444221e0f34392f3fda76ba/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_constants.mm |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ghendel@chromium.org
, Jul 2