(Windows) tentatively I can't tab into the app icons and app menu at all. Will wait for a second opinion here, but likely mac-only?

This is my bug and it does repro on Mac.

The NextAction date has arrived: 2018-07-06

Root cause:

  void BrowserAppMenuButton::Layout() {
    if (new_icon_) {
      new_icon_->SetBoundsRect(GetContentsBounds());
      ink_drop_container()->SetBoundsRect(GetLocalBounds());
      image()->SetBoundsRect(GetContentsBounds());
      return;
    }

    views::MenuButton::Layout();
  }

This skips laying out the focus ring, which is a child of the AppMenuButton. It only triggers when features::kAnimatedAppMenuIcon is enabled.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef462db922cc93016f1482433c26cf0479dd86aa

commit ef462db922cc93016f1482433c26cf0479dd86aa
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri Jul 06 19:46:49 2018

views: lay out focus ring on app menu button properly

When using the new animated app menu icon, it's necessary to call View::Layout
so that the focus ring is properly laid out.

Bug:  859642 
Change-Id: Icb2d39d0fa3f254fb996899f8d2fb8c0ad011c7e
Reviewed-on: https://chromium-review.googlesource.com/1127926
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573047}
[modify] https://crrev.com/ef462db922cc93016f1482433c26cf0479dd86aa/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc

Able to reproduce the issue on Mac 10.13.5 using chrome build without fix.

Verified the fix on Mac 10.13.5, as per comment#0 on latest chrome version #69.0.3486.0.
Attaching screen cast for reference.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!

Deleted: 859642.mp4 477 KB

	859642.mp4 477 KB View Download