Decrease tab divider color |
|||
Issue descriptionX buttons are now drawn on all tabs, relieving the pressure on dividers to draw a visual boundary for unfocused tabs. X buttons on unfocused tabs are painted GG800, giving our tab boundaries a 7.98 contrast ratio. I'd like to lighten the dividers so that they cause less visual noise. Actual divider color: 43% Expected divider color: 28% (1.75 ratio) ---- *Divider color is based on the tab background color blended to the opposite luma of white or GG900. That color is then blended at 43% alpha against the background to match the spec.
,
Jul 2
We still need the dividers to be a visual separator as tabs get narrower and close buttons hide. We have three options: 1) Leave the color as-is 2) Make dividers darker when close buttons hide 3) Pick a color in between 43% and 28% that provides sufficient contrast for dividers alone Which do you prefer, Alan?
,
Jul 2
I prefer #3. It's minimal collateral damage (but probably not surprising) from the recent x button resolution. #2 seems overly complicated and #1 feels problematic. I've CC'd Laura and emailing her directly for her input. Because we've never achieved full AA compliance in Canary or Stable, I suspect 'sufficient contrast' doesn't necessarily mean a full 4.5 ratio. There's things like shape and pattern that are taken into consideration as well. For instance, Stable's contrast (between background tab color and tab outline) is 1.9. But because it's drawn around the entire tab and repeated throughout the strip, I'd imagine the total effects were suitable. With the addition of the x button, I think visual boundaries can be shared amongst the x and the divider. Breakdown of values below: Current Canary's divider contrast (43): 2.52 Current Canary's x button contrast on background tabs: 7.98 Proposed divider contrast (28): 1.75 Alternate 1 (30): 1.84 Alternate 2 (35): 2.05
,
Jul 2
I like alternate 2 because it doesn't worsen the contrast of the separator compared to the stable tab stroke contrast.
,
Jul 2
#2 is fine with me as long it doesn't expand our EstimatedDays too far. I'll leave that to yall's judgement. X buttons are 800 in today's Canary, but the spec calls for 700. I don't mind the extra contrast in the button but something else has to give to smooth out the noise. https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g3232c09376_6_971
,
Jul 2
There's a bug on decreasing the X to 700 per spec once we add dynamic contrast boosting.
,
Jul 3
In the absence of Laura's feedback, let's start with a non-dynamic 30% (not 28%) divider color. We can then throttle up or down, and include dynamic-ness, in the next round of iteration. Or a new bug - whatever yall prefer. Thanks!
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b284c23430831b033293d14c000108e6e4b50b6 commit 0b284c23430831b033293d14c000108e6e4b50b6 Author: Allen Bauer <kylixrd@chromium.org> Date: Tue Jul 03 20:58:55 2018 [Material Refresh] Separator blend from 43% to 30% per comment in bug. Bug: 859620 Change-Id: I57b73343549028053aa5833587e28782815971c9 Reviewed-on: https://chromium-review.googlesource.com/1125127 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#572347} [modify] https://crrev.com/0b284c23430831b033293d14c000108e6e4b50b6/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
,
Jul 4
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix. Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using latest chrome version #69.0.3481.0 as per the comment #10. Attaching screen shot for reference. Observed that the tab divider color is decreased. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jul 9
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kylixrd@chromium.org
, Jul 2EstimatedDays: 1
Owner: kylixrd@chromium.org