New issue
Advanced search Search tips

Issue 859607 link

Starred by 1 user
Status: Assigned
Owner:
kelvinjiang@chromium.org
Cc:
tnagel@chromium.org
zalcorn@chromium.org
rdevlin....@chromium.org
qqwangxin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Google authored apps / extensions are incorrectly badged with "added by a third party" icon

Project Member Reported by jawag@chromium.org, Jul 2 
Chrome Version       : 67.0.3396.99 (Official Build) (64-bit) (cohort: Stable)
URLs (if applicable) : chrome://extensions

What steps will reproduce the problem?
(1) Navigate to the extensions page
(2) Scroll down the page to find a Google authored app or extension, such as Application Launcher for Google Drive (by Google)
(3) Observe that the app or extension has an "added by a third party" badge as shown in attached screenshot

What is the expected result?
This badge should not be displayed.
Screenshot (102).png
33.7 KB View Download

Comment 1 by dpa...@chromium.org, Jul 2

Cc: rdevlin....@chromium.org
Status: Available (was: Unconfirmed)
@Devlin: The related logic to choose source indicators is at [2]. Do you have any suggestions on how to fix? Also it seems to me that the fix belongs on the C++ side instead of the UI side. WDYT?

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/item_util.js?l=80-89

Comment 2 by zalcorn@google.com, Nov 29

Cc: tnagel@chromium.org qqwangxin@chromium.org
Hey folks, following up on this as I can still see this in M72. Can we get a fix in for this?

Comment 3 by rdevlin....@chromium.org, Dec 3

Owner: kelvinjiang@chromium.org
Status: Assigned (was: Available)
Kelvin, can you take a look at this, since you're doing some stuff in the chrome://extensions page?

I think the right solution here is probably to change the API to not consider installed-by-default extensions that update from the webstore as from a third party.  The code for that is here:
https://chromium.googlesource.com/chromium/src/+/bd12215beec3be14c8b0b618ac48defbbb171d84/chrome/browser/extensions/api/developer_private/extension_info_generator.cc#612

Comment 4 by kelvinjiang@chromium.org, Dec 4 

Quick question: how do I "reproduce" this on a fresh chromium build by having extensions be installed by default?

Comment 5 by tnagel@chromium.org, Dec 4 

Fastest repro is maybe on a Chromebook using an official image?

Comment 6 by rdevlin....@chromium.org, Dec 4 

I think Drive is bundled with all builds of Chrome, so just compiling an official build should be sufficient (and should be faster than an official image on CrOS).
►

Sign in to add a comment