New issue
Advanced search Search tips

Issue 859605 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-17
OS: Mac
Pri: 2
Type: ----



Sign in to add a comment

external/.../test-002.html in webkit_layout_tests failing on chromium.mac/Mac10.10 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 2

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of spqchan@google.com

external/.../test-002.html in webkit_layout_tests failing on chromium.mac/Mac10.10 Tests

Builders failed on: 
- Mac10.10 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcf7e652bb5c045e8186de68f35b009a044812bc

commit fcf7e652bb5c045e8186de68f35b009a044812bc
Author: spqchan <spqchan@chromium.org>
Date: Mon Jul 02 20:11:13 2018

Mark retargeting-focus-events/test-002.html as flaky

TBR=carlosk@chromium.org

Bug: 859605
Change-Id: I8a4c2d01321437cb5c9386f1f2195b2761b8c413
Reviewed-on: https://chromium-review.googlesource.com/1123110
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571984}
[modify] https://crrev.com/fcf7e652bb5c045e8186de68f35b009a044812bc/third_party/WebKit/LayoutTests/TestExpectations

Components: Blink>DOM>ShadowDOM
Labels: -Sheriff-Chromium
Owner: kochi@chromium.org
Status: Assigned (was: Available)
kochi@, could you take a look?
Flakiness dashboard for this:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=retargeting-focus-events%2Ftest-002.html

This is mainly happening on Mac10.10 and quite rare on other Mac versions.
Recently it failed / was flaky in a specific revision period (r573188-r573205)
for most Mac versions, but it already recovered, and no suspicious CL around
the start of the failures.

The test itself should be quite deterministic (it uses focus/blur events,
which occur synchronously) and considering the test doesn't show failures
on other platforms, it should not be marked "failure" but have to be analyzed.

Let me revert the TestExpectations change to see if it continues to be
failing / flaky.
Attaching the correct screenshot.
4NOLvZu02NQ.png
133 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43a9772ba70a1c0cd20a51bc587486e81e0b2c03

commit 43a9772ba70a1c0cd20a51bc587486e81e0b2c03
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Tue Jul 10 03:34:56 2018

Remove flaky expectation for shadow dom test

As I cannot reproduce the flakiness locally, let me tentatively
revert the flaky flag to see if the flakiness continues on bots.

The test (retargeting-focus-events/test-002.html) should be
deterministic and platform-independent. It could have been a
regression in some other part.

Bug: 859605
Change-Id: I102fdcf56a5c429a913ba7e905db46257ae3a24f
Reviewed-on: https://chromium-review.googlesource.com/1130562
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573609}
[modify] https://crrev.com/43a9772ba70a1c0cd20a51bc587486e81e0b2c03/third_party/WebKit/LayoutTests/TestExpectations

Labels: OS-Mac
NextAction: 2018-07-17
Will update in a week.
The NextAction date has arrived: 2018-07-17
Still both test-002.html and test-003.html shows some flakiness.
Let me take closer look again.
Components: -Blink>DOM>ShadowDOM Blink>HTML>Focus
Owner: ----
Status: Available (was: Assigned)
Still no idea why this flakiness happens.

Sign in to add a comment