Issue metadata
Sign in to add a comment
|
libchrome: failed to build with glibc 2.27 |
||||||||||||||||||||||
Issue description
With glibc 2.27,
emerge-samus libchrome
sandbox/linux/services/proc_util.cc:56:11: error: 'readdir_r' is deprecated [-Werror,-Wdeprecated-declarations]
while (!readdir_r(dir.get(), &e, &de) && de) {
^
,
Jul 9
it'd help to note in your commits that readdir_r->readdir is safe for glibc because it guarantees readdir is thread safe, and atm we aren't supporting other C libraries
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/external/libchrome/+/536f6cb9217032dfd1d4cdbfc35b5d1c316cec27 commit 536f6cb9217032dfd1d4cdbfc35b5d1c316cec27 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Jul 11 19:13:08 2018 libchrome: Remove usage of readdir_r() readdir_r() is deprecated, which causes build failures when using glibc-2.24 or newer headers. This CL replaces usage of readdir_r() with readdir(). Part of it is a cherry-pick of http://crrev.com/4e33415240d5799 BUG= chromium:859601 TEST=emerge-samus libchrome with glibc 2.27 Change-Id: If530eeb5faf7748b59fdd7a367a03ff02eaa95a1 Reviewed-on: https://chromium-review.googlesource.com/1123101 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> [modify] https://crrev.com/536f6cb9217032dfd1d4cdbfc35b5d1c316cec27/base/files/file_enumerator_posix.cc [modify] https://crrev.com/536f6cb9217032dfd1d4cdbfc35b5d1c316cec27/sandbox/linux/services/proc_util.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 5