New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859593 link

Starred by 1 user
Status: Fixed
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Build-Toolchain

Blocking:
issue 834385



Sign in to add a comment

rootdev: failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, Jul 2 
with glibc 2.27

emerge-samus rootdev

rootdev.c:145:10: error: 'readdir_r' is deprecated [-Werror,-Wdeprecated-declarations]
  while (readdir_r(dirp, entry, &next) == 0 && next) {
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/rootdev/+/182cfd35498e929a913baf49768dfc6440301b15

commit 182cfd35498e929a913baf49768dfc6440301b15
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Jul 07 01:48:46 2018

rootdev: remove deprecated readdir_r

glibc 2.27 has removed deprecated readdir_r, and we need to
use readdir to replace it.

BUG= chromium:859593 
TEST=FEATURES="test" USE="asan" emerge-samus rootdev

Change-Id: I52da7a24a077fe06a68c7092039e6c3b9ca361ae
Reviewed-on: https://chromium-review.googlesource.com/1123022
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/182cfd35498e929a913baf49768dfc6440301b15/rootdev.c

Comment 2 by vapier@chromium.org, Jul 9

Status: Fixed (was: Untriaged)
it'd help to note in your commits that readdir_r->readdir is safe for glibc because it guarantees readdir is thread safe, and atm we aren't supporting other C libraries
►

Sign in to add a comment