[MdRefresh] Separator is missing in Single Tab Mode |
||||||
Issue descriptionChrome Version: Canary 69.0.3478.0 OS: All What steps will reproduce the problem? (1) Enable MdRefresh (2) Open a window with a single tab (3) Take a look between the close button and the NTB on the tab in the Single Tab Mode What is the expected result? A separator would be nice. What happens instead? Without a separator it feels like something is missing :( Thanks Mehmet
,
Jul 2
Thank you :)
,
Jul 2
Issue 859694 has been merged into this issue.
,
Jul 3
Issue 859627 has been merged into this issue.
,
Jul 3
Triage: Promoting to P1
,
Jul 6
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93e913c148a1a54557c8b29517a4be2eab7949ea commit 93e913c148a1a54557c8b29517a4be2eab7949ea Author: Peter Kasting <pkasting@chromium.org> Date: Mon Jul 09 16:02:29 2018 Show separators in single-tab mode. Bug: 859585 Test: An active chrome window with one tab should have a white titlebar with a separator between the tab close X and trailing new tab button. Change-Id: I35c61f0a19f16f9020e4416efe735c2af0978219 Reviewed-on: https://chromium-review.googlesource.com/1128276 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573321} [modify] https://crrev.com/93e913c148a1a54557c8b29517a4be2eab7949ea/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/93e913c148a1a54557c8b29517a4be2eab7949ea/chrome/browser/ui/views/tabs/tab_controller.h [modify] https://crrev.com/93e913c148a1a54557c8b29517a4be2eab7949ea/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/93e913c148a1a54557c8b29517a4be2eab7949ea/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/93e913c148a1a54557c8b29517a4be2eab7949ea/chrome/browser/ui/views/tabs/tab_unittest.cc
,
Jul 9
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd44237deff45b5e048ac6178c1081df57e9b04f commit fd44237deff45b5e048ac6178c1081df57e9b04f Author: Fredrik Söderquist <fs@opera.com> Date: Tue Jul 10 10:12:30 2018 Scrub line-endings in chrome/browser/ui/views/tabs/tab.cc 93e913c148a1a54557c8b29517a4be2eab7949ea added mixed line-endings, making git unhappy. Remove the excess carriage returns (CRs.) Tbr: pkasting@chromium.org Bug: 859585 Change-Id: Ied4e1465491679a607c9f273da0c3d8cbc6be499 Reviewed-on: https://chromium-review.googlesource.com/1130528 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#573673} [modify] https://crrev.com/fd44237deff45b5e048ac6178c1081df57e9b04f/chrome/browser/ui/views/tabs/tab.cc
,
Jul 11
Tested the issue on latest chrome# 69.0.3488.0 on Mac 10.12.6, Windows-10 and Ubuntu 14.04. Able to verify the fix(Separator when single tab is opened) on both Mac and Windows, but unable to verify the fix on Linux because of different UI(i.e., when single tab is opened unable to find the separator) @Fredrik Söderquist: Please find the attached screenshot for your reference and help us in verifying the fix. Thanks!
,
Jul 11
This is for me, not Fredrik. The Linux screenshot in comment 10 is actually drawing the trailing separator, but it shouldn't be, since there's a clearly-visible active tab shape. Given that and the color of the new tab button (which was clearly chosen to contrast with a light frame and not a dark one), I think the frame in this case is reporting that single tab mode is available, but not drawing that way. This is GTK-specific, and I've filed it as bug 862629 . |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pkasting@chromium.org
, Jul 2Owner: pkasting@chromium.org
Status: Assigned (was: Untriaged)