New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859582 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Out until 24 Jan
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make success checks in NavigateToURLFromRenderer() more robust

Project Member Reported by alex...@chromium.org, Jul 2

Issue description

Currently, the NavigateToURLFromRenderer() helper checks success by comparing URLs, but that may be fragile with error pages.  Things should still work, since an error page shouldn't change the last committed URL for the observer, which is initially empty, but we should make this more robust and explicitly check that the navigation did not result in an error page.

Filing to follow up on a comment in https://chromium-review.googlesource.com/c/chromium/src/+/1122840/1/content/browser/frame_host/render_frame_host_manager_browsertest.cc#4449


 

Sign in to add a comment