Issue metadata
Sign in to add a comment
|
NetworkService: Figure out what to do about Net.ResourceDispatcherHost.OutstandingRequests.* histograms |
||||||||||||||||||||||
Issue descriptionNet.ResourceDispatcherHost.OutstandingRequests.Total and Net.ResourceDispatcherHost.OutstandingRequests.PerProcess are only recorded in ResourceDispatcherHost, which isn't used when the network service is enabled. We should figure out if we can just remove the histograms, or if we still need them. If the latter is the case, we'll need to figure out how to hook them up when the NetworkService is enabled. I don't believe that hooking up this histogram should block experimenting with the network service on Windows Canary.
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af8095de02ad6e6b5dff6ffdcb05cef7ffa4a312 commit af8095de02ad6e6b5dff6ffdcb05cef7ffa4a312 Author: Helen Li <xunjieli@chromium.org> Date: Mon Jul 09 22:57:09 2018 Obsolete Net.ResourceDispatcherHost.OutstandingRequests.* histograms These two histograms are unused. The related histograms have already been deprecated. This essentially reverts crrev.com/466197. Bug: 859569 Change-Id: Idfbe20823425576aff4eaed54fdc67339c24e007 Reviewed-on: https://chromium-review.googlesource.com/1129827 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#573499} [modify] https://crrev.com/af8095de02ad6e6b5dff6ffdcb05cef7ffa4a312/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/af8095de02ad6e6b5dff6ffdcb05cef7ffa4a312/content/browser/loader/resource_dispatcher_host_impl.h [modify] https://crrev.com/af8095de02ad6e6b5dff6ffdcb05cef7ffa4a312/tools/metrics/histograms/histograms.xml
,
Jul 9
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xunji...@chromium.org
, Jul 5Owner: xunji...@chromium.org
Status: Assigned (was: Untriaged)