New issue
Advanced search Search tips

Issue 859555 link

Starred by 2 users
Status: Verified
Owner:
justincohen@chromium.org
Closed: Jul 17
Cc:
gambard@chromium.org
justincohen@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Fake omnibox is truncated

Project Member Reported by shbarezer@chromium.org, Jul 2 
App Version: 69.0.3479.0 canary
iOS Version: 11.4.1 beta 4, 12.0
Device: iPhone x, iPhone 7
URL: 

Steps to reproduce:
  1. Launch Google Chrome
  2. Tap on Tab switcher
  3. Change device mode to landscape
  4. Open the tab

Observed results: Fake omnibox is truncated

Expected results: Fake omnibox should not be truncated

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: , Safari: NA

Link to video/image:
https://drive.google.com/file/d/1NDNGYOY7VMkohX9xAUf1FnFqVmhwQ6-P/view

Comment 1 by pkl@chromium.org, Jul 2

Cc: justincohen@chromium.org
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by gambard@chromium.org, Jul 3

Cc: gambard@chromium.org
Owner: justincohen@chromium.org
Assigning to Justin as it is NTP related.

Comment 3 by gambard@chromium.org, Jul 3

Labels: -Pri-2 Q2 Pri-1

Comment 4 by stkhapugin@chromium.org, Jul 3

Labels: -MS-Omnibox

Comment 5 by rakurati@chromium.org, Jul 6

Labels: -Restrict-View-Google S-New-Tab-Faketoolbar MS-New-Tab

Comment 6 by marq@chromium.org, Jul 10

Labels: M-69

Comment 7 by justincohen@chromium.org, Jul 17

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6807a9f440f88525c90d1b01de24155c74228053

commit 6807a9f440f88525c90d1b01de24155c74228053
Author: Justin Cohen <justincohen@google.com>
Date: Tue Jul 17 11:55:44 2018

[ios] Update NTP header view constraints on view load.

Bug:  859555 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6c4c564f12ee0acb89fdcc9538f89e4277f1461a
Reviewed-on: https://chromium-review.googlesource.com/1139528
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575605}
[modify] https://crrev.com/6807a9f440f88525c90d1b01de24155c74228053/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_controlling.h
[modify] https://crrev.com/6807a9f440f88525c90d1b01de24155c74228053/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/6807a9f440f88525c90d1b01de24155c74228053/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizing.h
[modify] https://crrev.com/6807a9f440f88525c90d1b01de24155c74228053/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/6807a9f440f88525c90d1b01de24155c74228053/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 9 by justincohen@chromium.org, Jul 17

Status: Fixed (was: Started)

Comment 10 by srikanthg@chromium.org, Jul 24

Status: Verified (was: Fixed)
Verified on M70.0.3501.0 canary
Device: iPhoneSE, iPhone7Plus, iPhoneX
iOS: 11.4.1, 10.3.3, 12.0 beta#4

Omnibox looks good after following the steps from the report.
►

Sign in to add a comment