Refresh: omnibox text moves when you trigger zero suggest |
|||||||||||||||
Issue descriptionChrome Version: 69.0.3478.0 OS: MacOS What steps will reproduce the problem? (1)airbnb.com, chase.com, any EV cert site (2)focus omnibox (3)see airbnb.com jog to the right without typing What is the expected result? URL should not move upon focus
,
Jul 3
The issue here is not actually the EV cert chip, it's contextual zero suggest.
,
Aug 1
Even if the text should move on input ( issue 859540 ), it shouldn't move in this case (zero suggest). The presence of text in the location icon button means that the text in the omnibox and the text in the suggestions won't line up regardless, so adding additional indent just moves the text for no apparent reason.
,
Aug 2
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6310a574660cea1442fd5a932d9963ecec12c321 commit 6310a574660cea1442fd5a932d9963ecec12c321 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Fri Aug 03 16:46:55 2018 [omnibox] Don't indent the text if the location icon text is showing. The point of the text indent is to align with the suggestions in the dropdown. But if the location icon has text, it won't align anyway so the indent is not useful and looks odd. Bug: 859543 Change-Id: I355c81016a2691bcc237b108eec80318dccf1b50 Reviewed-on: https://chromium-review.googlesource.com/1159229 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#580571} [modify] https://crrev.com/6310a574660cea1442fd5a932d9963ecec12c321/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/6310a574660cea1442fd5a932d9963ecec12c321/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h [modify] https://crrev.com/6310a574660cea1442fd5a932d9963ecec12c321/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Aug 3
tommycli: would you mind verifying this and requesting merge on Monday?
,
Aug 6
Unable to reproduce the issue on reported chrome version 69.0.3478.0 using Windows, Mac 10.13.5 and Ubuntu 17.10.Attaching screen-cast for reference. Steps: --------- 1. Launched reported Chrome 2. Navigated to given URL's in the comment #0 as per attached screen-cast 3. Focused on omnibox by clicking tab We have Observed that "URL not moved upon focus" @Reporter: Please find the attached screen-cast and let us know if we have missed anything in the process. Thanks!
,
Aug 6
Re c#7, try it again with chrome://flags/#upcoming-ui-features enabled and nothing else. Make sure you are signed in and syncing as well.
,
Aug 6
I just tested it. I can verify that: - The original bug reproduces on: 3510.2 - It's fixed on: 3514.0 (Today's Canary)
,
Aug 6
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 6
Re: Merge Review This is a user visible change with low technical risk. It's not as critical as a crash, but it has a good benefit to risk ratio, so it's merge-worthy in my opinion.
,
Aug 6
Approving merge to M69 branch 3497 based on comment #9 and #11. Please merge. Thank you.
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8478d21fe29ce1e19b198b38c0f976c158ff1401 commit 8478d21fe29ce1e19b198b38c0f976c158ff1401 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Mon Aug 06 19:22:35 2018 [omnibox] Don't indent the text if the location icon text is showing. The point of the text indent is to align with the suggestions in the dropdown. But if the location icon has text, it won't align anyway so the indent is not useful and looks odd. Bug: 859543 Change-Id: I355c81016a2691bcc237b108eec80318dccf1b50 Reviewed-on: https://chromium-review.googlesource.com/1159229 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580571}(cherry picked from commit 6310a574660cea1442fd5a932d9963ecec12c321) Reviewed-on: https://chromium-review.googlesource.com/1163943 Cr-Commit-Position: refs/branch-heads/3497@{#429} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/8478d21fe29ce1e19b198b38c0f976c158ff1401/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/8478d21fe29ce1e19b198b38c0f976c158ff1401/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h [modify] https://crrev.com/8478d21fe29ce1e19b198b38c0f976c158ff1401/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Aug 6
Merged to 69. Thanks all!
,
Aug 7
Test team was not able to repro, hence cannot verify the fix. bettes@ would you mind verifying?
,
Aug 7
Re c#7, try it again with chrome://flags/#upcoming-ui-features enabled and nothing else. Make sure you are signed in and syncing as well.
,
Aug 8
Able to reproduce the issue on Mac 10.13.5, Windows 10 and Ubuntu 17.10 on reported version 69.0.3478.0. Verified the fix on Mac 10.13.5, Windows 10 and Ubuntu 17.10, as per comment#16 on latest chrome version #70.0.3515.0 and 70.0.3514.0. Attaching screen shot for reference. Observed that the URL is not moving upon focus Hence, the fix is working as expected. Adding the verified labels. Thanks...!
,
Aug 9
Able to reproduce the issue on Mac 10.13.5, Windows 10 and Ubuntu 17.10 on reported version 69.0.3478.0. Verified the fix on Mac 10.13.5, Windows 10 and Ubuntu 17.10,on chrome version #69.0.3497.32. Attaching screen shot for reference. Observed that the URL is not moving upon focus Hence, the fix is working as expected. Adding the verified labels. Thanks...!
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by skare@google.com
, Jul 3