Issue metadata
Sign in to add a comment
|
NetworkService: Figure out what to do about prefetch histograms. |
||||||||||||||||||||||||
Issue descriptioncontent/browser/loader/ has a number of prefetch related histograms that we'll lose when the network service is enabled. We should figure out if we can just remove the histograms, or if we still need them. If the latter is the case, we'll need to figure out how to hook them up when the NetworkService is enabled. The histograms are: Net.Prefetch.TimeSpentPrefetchingFromCache Net.Prefetch.TimeSpentPrefetchingFromNetwork Net.Prefetch.TimeBeforeCancel Net.LoadPrefetch.Pattern Net.Prefetch.Pattern Net.Prefetch.TimeSpentOnPrefetchHit Whatever the decision here, I don't believe hooking up these histograms should block running experiments on Windows canary.
,
Jul 2
/me too, cannot recall when we last looked at them. I guess if something goes wrong with prefetches (and we notice it first in the field - not too likely), Net.Prefetch* may potentially help trim some hypothesis (another unlikely). Another possible avenue is us experimenting on something like changing the 5min interval unused_since_prefetch, not planned for 2018 .. +1 to remove
,
Jul 2
Thanks for the quick feedback, both of you! I'll go ahead and send out a CL to remove them.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/185e5edc88672d304a4db6d65397b3c3b5a721b9 commit 185e5edc88672d304a4db6d65397b3c3b5a721b9 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jul 03 16:02:53 2018 Remove some prefetching histograms. The histograms are being recorded in code that isn't used when the network service is enabled. It was decided that these histograms see little enough use that it was better to remove them, rather than make them work with the network service. In particular, the histograms are: Net.Prefetch.TimeSpentPrefetchingFromCache Net.Prefetch.TimeSpentPrefetchingFromNetwork Net.Prefetch.TimeBeforeCancel Net.LoadPrefetch.Pattern Net.Prefetch.Pattern Net.Prefetch.TimeSpentOnPrefetchHit Bug: 859535 Change-Id: Idc85a43ce4a7b2c959c419401c422d17b07e35d3 Reviewed-on: https://chromium-review.googlesource.com/1122703 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#572243} [modify] https://crrev.com/185e5edc88672d304a4db6d65397b3c3b5a721b9/content/browser/loader/resource_loader.cc [modify] https://crrev.com/185e5edc88672d304a4db6d65397b3c3b5a721b9/content/browser/loader/resource_loader.h [modify] https://crrev.com/185e5edc88672d304a4db6d65397b3c3b5a721b9/tools/metrics/histograms/histograms.xml
,
Jul 3
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jkarlin@chromium.org
, Jul 2