New issue
Advanced search Search tips

Issue 859532 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Jul 2
Cc:
csharrison@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NetworkService: Figure out what to do about resource loading histograms.

Project Member Reported by mmenke@chromium.org, Jul 2 
When the network service is enabled, RDH and ResourceLoader histograms won't be recorded.  We should either remove the affected histograms, or port them to work with the network service enabled.  This is a catch-all bug for the loading-related subset of this histograms owned by csharrison (Just because he owns them doesn't mean he's solely responsible for porting them, just that he has the best context on whether or not we should port them).

The histogram list:
Net.RequestTime2Success.MainFrame
Net.ErrAborted.SentBytes
Net.ErrAborted.ReceivedBytes
Net.RequestTime2Success.Subresource
Net.ResourceLoader.TimeToURLRequestStart

I don't believe these histograms should block experimenting with the network service on Canary.

Comment 1 by mmenke@chromium.org, Jul 2

Cc: csharrison@chromium.org
[+csharrison]:  Would appreciate your opinion on whether we still need all these histograms.

Comment 2 by csharrison@chromium.org, Jul 2 

I think these can all be removed. The "Success" ones are pretty useful but we can probably just added them later as needed.

Comment 3 by mmenke@chromium.org, Jul 2

Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
Thanks!  I'll go ahead and remove them (I feel that removing them before the switch to the network service makes for less friction then if we just rely on switching the network service to incidentally also remove them, in addition to everything else it will do).

Comment 4 by csharrison@chromium.org, Jul 2 

Plan SGTM
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffb0211bba3b2612d89f73e6a3026b8d8fdd1f66

commit ffb0211bba3b2612d89f73e6a3026b8d8fdd1f66
Author: Matt Menke <mmenke@chromium.org>
Date: Mon Jul 02 20:02:45 2018

Remove a couple loading-related histogram from content/browser/loader/

Most of the code there isn't used when the network service is disabled,
and we decided to remove some of the histograms, rather than updating
them to work when the network service is enabled. We may bring some of
these back in the future.

The histograms this CL removes are:
Net.RequestTime2Success.MainFrame
Net.ErrAborted.SentBytes
Net.ErrAborted.ReceivedBytes
Net.RequestTime2Success.Subresource
Net.ResourceLoader.TimeToURLRequestStart

Bug:  859532 
Change-Id: Ib48e2b50058771881ef5f1539a5f70d6f142922e
Reviewed-on: https://chromium-review.googlesource.com/1122702
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571982}
[modify] https://crrev.com/ffb0211bba3b2612d89f73e6a3026b8d8fdd1f66/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/ffb0211bba3b2612d89f73e6a3026b8d8fdd1f66/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/ffb0211bba3b2612d89f73e6a3026b8d8fdd1f66/tools/metrics/histograms/histograms.xml

Comment 6 by mmenke@chromium.org, Jul 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment