New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859528 link

Starred by 1 user
Status: Fixed
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Build-Toolchain

Blocking:
issue 834385



Sign in to add a comment

punnybench: failed to build with lglibc 2.27

Project Member Reported by yunlian@chromium.org, Jul 2 
With glibc 2.27, I got
fcalls.c: In function 'readdir_rk':
fcalls.c:681:2: error: 'readdir_r' is deprecated (declared at ../../../../../../../usr/include/dirent.h:189) [-Werror=deprecated-declarations]
  s64 rc = readdir_r(dir, entry, result);
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/punybench/+/16bc496a97c027147453e7d675ae2f9147352b31

commit 16bc496a97c027147453e7d675ae2f9147352b31
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue Jul 03 07:48:16 2018

punybench: remove readdir_r

`readdir_r` is deprecated in glibc 2.24.
It is advised to use the readdir instead.

BUG= chromium:859528 
TEST=emerge-samus punybench passes with glibc 2.27

Change-Id: I108c37eb3509137e72839727e6f2bc759e215deb
Reviewed-on: https://chromium-review.googlesource.com/1122844
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

[modify] https://crrev.com/16bc496a97c027147453e7d675ae2f9147352b31/fcalls.d/fcalls.h
[modify] https://crrev.com/16bc496a97c027147453e7d675ae2f9147352b31/fcalls.d/wrapper.h
[modify] https://crrev.com/16bc496a97c027147453e7d675ae2f9147352b31/fcalls.d/dir.c
[modify] https://crrev.com/16bc496a97c027147453e7d675ae2f9147352b31/fcalls.d/fcalls.c

Comment 2 by vapier@chromium.org, Jul 9

Status: Fixed (was: Untriaged)
it'd help to note in your commits that readdir_r->readdir is safe for glibc because it guarantees readdir is thread safe, and atm we aren't supporting other C libraries
►

Sign in to add a comment