New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859514 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-12
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 843729



Sign in to add a comment

Remove BattOr power benchmarks and the code that supports them

Project Member Reported by charliea@chromium.org, Jul 2

Issue description

As decided in https://docs.google.com/document/d/1c_0bN9OdcvqGJwljqiKeo5m7RKpfjBPk4cY6PcmSwaA/edit, we're no longer going to use BattOr power measurement on the perf waterfall. The low number of regressions that they catch just doesn't justify the high cost of keeping them on the waterfall.

This bug will be used to track this effort.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e91e65d84157bc3acdca3025f954953975a3a8f1

commit e91e65d84157bc3acdca3025f954953975a3a8f1
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Jul 02 21:06:08 2018

Stop monitoring power using BattOrs on the perf waterfall

As decided in https://goo.gl/g5Srzn, the low number of regressions
caught by the power metrics alone doesn't justify the high cost of
maintaining the BattOrs on the waterfall.

Bug:  859514 
Change-Id: I012e2692963c30793b6843e2844d77cdf75d7d3e
Reviewed-on: https://chromium-review.googlesource.com/1122485
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571997}
[modify] https://crrev.com/e91e65d84157bc3acdca3025f954953975a3a8f1/tools/perf/benchmarks/media.py
[modify] https://crrev.com/e91e65d84157bc3acdca3025f954953975a3a8f1/tools/perf/benchmarks/power.py
[modify] https://crrev.com/e91e65d84157bc3acdca3025f954953975a3a8f1/tools/perf/benchmarks/system_health.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/ce6b2fbbac200f71678c8477af6fa91fc620e850

commit ce6b2fbbac200f71678c8477af6fa91fc620e850
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Jul 03 16:58:50 2018

Remove BattOr support from Telemetry

As decided in https://goo.gl/g5Srzn, the low number of regressions
caught by the power metrics alone doesn't justify the high cost of
maintaining the BattOrs on the waterfall or support for BattOr tracing
in Telemetry.

To be done in later CLs:

- Remove support for the concept of nonfatal exceptions in Telemetry.
  BattOr was the only use case for this concept and leaving it around
  just adds unnecessary mental overhead.
- Remove support from systrace
- Remove all BattOr code from common/battor

Bug:  chromium:859514 
Change-Id: Ic3c79e80520826483223af4d43f5e735e45cb87f
Reviewed-on: https://chromium-review.googlesource.com/1124678
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/benchmark.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/core/platform.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/internal/util/binary_manager.py
[delete] https://crrev.com/9f46241c6c03d9ffb2422e85a362f0bab5d4215f/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/internal/platform/tracing_controller_backend_unittest.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/value/trace_unittest.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/timeline/tracing_config.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/internal/platform/android_platform_backend.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/internal/platform/tracing_controller_backend.py
[delete] https://crrev.com/9f46241c6c03d9ffb2422e85a362f0bab5d4215f/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/internal/platform/platform_backend.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/PRESUBMIT.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/__init__.py
[modify] https://crrev.com/ce6b2fbbac200f71678c8477af6fa91fc620e850/telemetry/telemetry/core/tracing_controller_unittest.py

Cc: bpastene@chromium.org
CCing Ben Pastene. Ben, my understanding is that you have some glue code that makes sure that BattOrs are exposed correctly to each container on our dockerized bots. We're turning down support for BattOr on the waterfall, so that code can be deleted.
We do indeed have some battor code pinned from catapult into the docker stuff:
https://chromium.googlesource.com/infra/infra/+/master/infra/services/android_docker/third_party/battor/

I'll work on removing that; thnx for the heads-up!
Np - thanks for your help with all of the BattOr stuff to start with! It was very much appreciated.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/911aa65fd704c7e5191d7cbd6749effeae188613

commit 911aa65fd704c7e5191d7cbd6749effeae188613
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 03 19:24:43 2018

Roll src/third_party/catapult 9f46241c6c03..ce6b2fbbac20 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/9f46241c6c03..ce6b2fbbac20


git log 9f46241c6c03..ce6b2fbbac20 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 charliea@chromium.org Remove BattOr support from Telemetry


Created with:
  gclient setdep -r src/third_party/catapult@ce6b2fbbac20

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:859514 
TBR=sullivan@chromium.org

Change-Id: Iab7c470fa766f99277ff2b867dbfa6160c0983cd
Reviewed-on: https://chromium-review.googlesource.com/1124901
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572318}
[modify] https://crrev.com/911aa65fd704c7e5191d7cbd6749effeae188613/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/3eb704babdf78662fe72b8c64f1d9f5089e9328e

commit 3eb704babdf78662fe72b8c64f1d9f5089e9328e
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Jul 03 19:47:16 2018

Remove BattOr support from systrace

As decided in https://goo.gl/g5Srzn, the low number of regressions
caught by the power metrics alone doesn't justify the high cost of
maintaining the BattOrs on the waterfall or the Python code that
supports BattOr tracing.

Bug:  chromium:859514 
Change-Id: Ib72a2ef03be1773dcbc865f380b9bd968b603cba
Reviewed-on: https://chromium-review.googlesource.com/1124957
Reviewed-by: Chris Craik <ccraik@google.com>
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/systrace/systrace/systrace_runner.py
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/tracing/tracing/trace_data/trace_data.py
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/systrace/systrace/output_generator.py
[delete] https://crrev.com/10e0a3798e47192037de47c9f258e16aa18cccbf/systrace/systrace/test_data/battor_test_data.txt
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/tracing/tracing/trace_data/trace_data_unittest.py
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/systrace/systrace/tracing_agents/walt_agent_unittest.py
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/systrace/PRESUBMIT.py
[delete] https://crrev.com/10e0a3798e47192037de47c9f258e16aa18cccbf/systrace/systrace/tracing_agents/battor_trace_agent_unittest.py
[delete] https://crrev.com/10e0a3798e47192037de47c9f258e16aa18cccbf/systrace/systrace/tracing_agents/battor_trace_agent.py
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/systrace/systrace/run_systrace.py
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/systrace/systrace/output_generator_unittest.py
[modify] https://crrev.com/3eb704babdf78662fe72b8c64f1d9f5089e9328e/systrace/systrace/__init__.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/788597c285717d8f87f2ed715b45470b3f85838d

commit 788597c285717d8f87f2ed715b45470b3f85838d
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 03 22:47:30 2018

Roll src/third_party/catapult 10e0a3798e47..3eb704babdf7 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/10e0a3798e47..3eb704babdf7


git log 10e0a3798e47..3eb704babdf7 --date=short --no-merges --format='%ad %ae %s'
2018-07-03 charliea@chromium.org Remove BattOr support from systrace


Created with:
  gclient setdep -r src/third_party/catapult@3eb704babdf7

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:859514 
TBR=sullivan@chromium.org

Change-Id: I77110c5bfbacc34da473d6ff60d08b2aba9859c0
Reviewed-on: https://chromium-review.googlesource.com/1125239
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572380}
[modify] https://crrev.com/788597c285717d8f87f2ed715b45470b3f85838d/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73cc1f2a4d6b99b06b64bacc09adf52dbcae4246

commit 73cc1f2a4d6b99b06b64bacc09adf52dbcae4246
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Jul 09 17:17:56 2018

Update Telemetry power harness documentation to the post-BattOr world

As decided in https://goo.gl/g5Srzn, the low number of regressions
caught by the power metrics alone doesn't justify the high cost of
maintaining BattOrs support in Telemetry.

Bug:  859514 
Change-Id: If96a596f4bfaa0fb69779f049f1022e1b48c7f99
Reviewed-on: https://chromium-review.googlesource.com/1125123
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#573345}
[modify] https://crrev.com/73cc1f2a4d6b99b06b64bacc09adf52dbcae4246/docs/speed/benchmark/harnesses/power_perf.md

Owner: bpastene@chromium.org
Ben, it looks like a lot of the rest of the code is being imported by your docker container logic, so I'll have to hold off on deleting it until the docker stuff is deleted. Do you have any idea when that might be?
NextAction: 2018-07-12
I'll plan on working on deleting it on Thurs.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e72208df845b9c44f5ec066ea03e41cbe8a7024

commit 5e72208df845b9c44f5ec066ea03e41cbe8a7024
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Jul 11 01:08:36 2018

Remove power.idle_platform benchmark

This benchmark is no longer necessary now that we are no longer using
ground-truth power in our integration testing.

Bug:  859514 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9d9fd8d5a629d903e38a9ad5d5e03a2fda58c650
Reviewed-on: https://chromium-review.googlesource.com/1130008
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574023}
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/benchmark.csv
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/benchmarks/power.py
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/benchmark_sharding_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/android_nexus5_16_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/android_nexus5x_16_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/android_nexus5x_webview_16_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/android_nexus6_webview_16_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/android_one_16_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/linux_perf_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/mac1012_5_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/mac_1012_low_end_26_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/mac_1013_high_end_26_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/pixel2_7_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/pixel2_webview_7_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/android_nexus5x_webview_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/linux_perf_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/mac1012_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/mac_1012_low_end_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/mac_1013_high_end_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/pixel2_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/win10_highdpi_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/win10_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/win7_nvidia_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/timing_data/win7_story_timing.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/win10_highdpi_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/win10_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/win7_nvidia_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/core/shard_maps/win7_shard_map.json
[modify] https://crrev.com/5e72208df845b9c44f5ec066ea03e41cbe8a7024/tools/perf/expectations.config

The NextAction date has arrived: 2018-07-12
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/51df80af3230bec26aa17f13ad8e64f2516ac2d7

commit 51df80af3230bec26aa17f13ad8e64f2516ac2d7
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Jul 12 17:14:35 2018

android_docker: Tear out battor internals.

Bug:  859514 
Change-Id: I7bea28aa91bb59c5428e2ee902bb07b1a8e201a4
Reviewed-on: https://chromium-review.googlesource.com/1135450
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/51df80af3230bec26aa17f13ad8e64f2516ac2d7/infra/services/android_docker/test/usb_device_test.py
[modify] https://crrev.com/51df80af3230bec26aa17f13ad8e64f2516ac2d7/infra/services/android_docker/containers.py
[delete] https://crrev.com/29198bc19c95ffd4f0955bfd89ad3c886a371a77/infra/services/android_docker/third_party/battor/battor_error.py
[delete] https://crrev.com/29198bc19c95ffd4f0955bfd89ad3c886a371a77/infra/services/android_docker/third_party/battor/battor_wrapper.py
[delete] https://crrev.com/29198bc19c95ffd4f0955bfd89ad3c886a371a77/infra/services/android_docker/third_party/battor/__init__.py
[modify] https://crrev.com/51df80af3230bec26aa17f13ad8e64f2516ac2d7/infra/services/android_docker/usb_device.py
[modify] https://crrev.com/51df80af3230bec26aa17f13ad8e64f2516ac2d7/infra/services/android_docker/test/containers_test.py
[modify] https://crrev.com/51df80af3230bec26aa17f13ad8e64f2516ac2d7/infra/services/android_docker/third_party/README.infra
[delete] https://crrev.com/29198bc19c95ffd4f0955bfd89ad3c886a371a77/infra/services/android_docker/third_party/battor/battor_binary_dependencies.json

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/7436de9087f13e6382971f0528f3439f0f30833a

commit 7436de9087f13e6382971f0528f3439f0f30833a
Author: Ben Pastene <bpastene@chromium.org>
Date: Thu Jul 12 19:41:00 2018

#15 rolls the docker changes to all bots in production

If nothing breaks, then we should be g2g
Owner: charliea@chromium.org
Battor support has been removed from android docker stuff and things look good. Back to Charlie
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f5342c4cf3d3e85e43be84c22bdfd8ebff23ec70

commit f5342c4cf3d3e85e43be84c22bdfd8ebff23ec70
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Jul 16 15:30:41 2018

Delete remaining BattOr-related code in Catapult

Because there's a circular dependency between the devil code (which
imports BattOr errors) and the common/battor code (which relies on the
devil code to find BattOrs), it's easiest to just delete this all in a
single CL.

Last week, bpastene@ deleted the infra code that relied on this code
to map BattOrs to docker hosts.

Bug:  chromium:859514 
Change-Id: I815ff92ffc4ddb69ffaf68a80be661c580d50aed
Reviewed-on: https://chromium-review.googlesource.com/1138396
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>

[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/bin/run_py_tests
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/battor/battor_wrapper.py
[modify] https://crrev.com/f5342c4cf3d3e85e43be84c22bdfd8ebff23ec70/catapult_build/build_steps.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/battor/battor_error.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/battor/battor_wrapper_devicetest.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/devil/devil/utils/test/data/test_serial_map.json
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/battor/battor_wrapper_unittest.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/bin/upload_battor_binaries.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/battor/__init__.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/devil/devil/utils/battor_device_mapping.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/OWNERS
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/devil/devil/utils/update_mapping.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/battor/battor_binary_dependencies.json
[modify] https://crrev.com/f5342c4cf3d3e85e43be84c22bdfd8ebff23ec70/devil/devil/utils/find_usb_devices_test.py
[modify] https://crrev.com/f5342c4cf3d3e85e43be84c22bdfd8ebff23ec70/devil/devil/utils/__init__.py
[delete] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/common/battor/bin/.gitignore

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68779fa7a1e16b4a4644088b47dbe2d6e7beb46d

commit 68779fa7a1e16b4a4644088b47dbe2d6e7beb46d
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jul 16 17:42:22 2018

Roll src/third_party/catapult be45355b46d9..f5342c4cf3d3 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/be45355b46d9..f5342c4cf3d3


git log be45355b46d9..f5342c4cf3d3 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 charliea@chromium.org Delete remaining BattOr-related code in Catapult


Created with:
  gclient setdep -r src/third_party/catapult@f5342c4cf3d3

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:859514 
TBR=sullivan@chromium.org

Change-Id: I300a70ed0222a645f762d4e8f8d89cd0877f034b
Reviewed-on: https://chromium-review.googlesource.com/1138454
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575334}
[modify] https://crrev.com/68779fa7a1e16b4a4644088b47dbe2d6e7beb46d/DEPS

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c7acf2d8e3f91e06ee92fb71637d7de967e1fc0

commit 5c7acf2d8e3f91e06ee92fb71637d7de967e1fc0
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Jul 30 16:02:47 2018

Remove the BattOr power_tracing agent from Chrome tracing

As decided in https://goo.gl/g5Srzn, we're no longer doing BattOr power
measurement on the waterfall and consequently can't justify maintaining
the significant C++ code required to do interactive BattOr tracing.

This is the first Chrome-side CL to delete that code.

(For additional context, see https://goo.gl/P9AR84 (google internal)
or ping me to chat.)

TBR=avi for BUILD.gn

Bug:  859514 
Change-Id: I4b6c0c6ac40abe9c593ce24e1bb0d68a4eeacd42
Reviewed-on: https://chromium-review.googlesource.com/1122489
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579055}
[modify] https://crrev.com/5c7acf2d8e3f91e06ee92fb71637d7de967e1fc0/content/browser/BUILD.gn
[delete] https://crrev.com/6f9db5e75797a2dd4b2fefe8d7396c0fa0a39b5f/content/browser/tracing/power_tracing_agent.cc
[delete] https://crrev.com/6f9db5e75797a2dd4b2fefe8d7396c0fa0a39b5f/content/browser/tracing/power_tracing_agent.h
[modify] https://crrev.com/5c7acf2d8e3f91e06ee92fb71637d7de967e1fc0/content/browser/tracing/tracing_controller_impl.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10124a83bb8289af345366dbc9735bae9bf01d8

commit e10124a83bb8289af345366dbc9735bae9bf01d8
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Aug 06 16:13:59 2018

Remove remaining references to BattOr in tools/perf

TBR=sullivan@chromium.org

Bug:  859514 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I7b6c0203596df67d668c18a084039c1832b3f52b
Reviewed-on: https://chromium-review.googlesource.com/1162628
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580891}
[modify] https://crrev.com/e10124a83bb8289af345366dbc9735bae9bf01d8/tools/perf/core/sharding_map_generator.py
[modify] https://crrev.com/e10124a83bb8289af345366dbc9735bae9bf01d8/tools/perf/expectations.config

Blocking: 843729
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/483985150f7b5249cee49179cdd36411a3c6f25e

commit 483985150f7b5249cee49179cdd36411a3c6f25e
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Aug 07 18:01:16 2018

Remove BattOrs from Chrome-wide builders

BattOr is being removed from Chrome tracing. Before the code for it
can be deleted, we need to do this.

TBR=inferno@chromium.org

Bug:  859514 
Change-Id: I3f88e147570e05c4056052aebfc085648231a4f3
Reviewed-on: https://chromium-review.googlesource.com/1162631
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581276}
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/chromium.win.json
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/483985150f7b5249cee49179cdd36411a3c6f25e/tools/code_coverage/test_suite.txt

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c8d3a564862dd7f9f583057c40093a025de1754e

commit c8d3a564862dd7f9f583057c40093a025de1754e
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Aug 08 20:48:40 2018

Remove the BattOr agent builders from the Chromium Perf FYI waterfall

The code for this binary will be disappearing soon, so these builders
aren't needed anymore. I'll reach out to vhang@ to take these builders
offline.

R=nednguyen@chromium.org

Bug:  859514 
Change-Id: I62a9f8ea4fa72a4d81d31a60da7413c3a5edcbd7
Reviewed-on: https://chromium-review.googlesource.com/1167974
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/c8d3a564862dd7f9f583057c40093a025de1754e/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24cbbc10d78ea1c3b5b1a4e25a50b8dcc1c026e4

commit 24cbbc10d78ea1c3b5b1a4e25a50b8dcc1c026e4
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Aug 08 23:27:34 2018

Remove BattOr builders from mb_config.pyl

The BattOr code is soon going to be delete and these builders
aren't needed anymore.

R=dpranke@chromium.org
CC=​nednguyen@chromium.org

Bug:  859514 
Change-Id: I30c0f8ada35a0ff2070228e667b29258de5aa9a5
Reviewed-on: https://chromium-review.googlesource.com/1167975
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581723}
[modify] https://crrev.com/24cbbc10d78ea1c3b5b1a4e25a50b8dcc1c026e4/tools/mb/mb_config.pyl

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed0cd302050da8be35eb52c84583f5610dbac08a

commit ed0cd302050da8be35eb52c84583f5610dbac08a
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu Aug 09 00:06:25 2018

Delete all remaining BattOr agent code and references to that code

See the linked bug more context about the rationale behind removing
BattOr tracing from Chrome. At a high level, we didn't find enough
regressions to justify maintaining the BattOr hardware on the perf
waterfall and, without BattOrs on the waterfall, we couldn't justify
maintaining the BattOr tracing code.

+dpranke@ for tools/determinism OWNERS
+reillyg@ for device/ OWNERS
+jam@ for src/BUILD.gn

Bug:  859514 
Change-Id: Ibe60830be79141afdd66ed50d54cbfab8ea1b95a
Reviewed-on: https://chromium-review.googlesource.com/1167982
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581726}
[modify] https://crrev.com/ed0cd302050da8be35eb52c84583f5610dbac08a/BUILD.gn
[modify] https://crrev.com/ed0cd302050da8be35eb52c84583f5610dbac08a/device/serial/BUILD.gn
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/device/serial/test_serial_io_handler.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/device/serial/test_serial_io_handler.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/BUILD.gn
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/DEPS
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/OWNERS
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/README
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_agent.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_agent.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_agent_bin.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_agent_unittest.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_connection.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_connection.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_connection_impl.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_connection_impl.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_connection_impl_unittest.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_error.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_error.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_finder.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_finder.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_protocol_types.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_protocol_types_unittest.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_sample_converter.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_sample_converter.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/battor_sample_converter_unittest.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/serial_utils.cc
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/serial_utils.h
[delete] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/tools/battor_agent/serial_utils_unittest.cc
[modify] https://crrev.com/ed0cd302050da8be35eb52c84583f5610dbac08a/tools/determinism/deterministic_build_whitelist.pyl

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/520452bcf840374e713a2053eb0645ee6ca18b7f

commit 520452bcf840374e713a2053eb0645ee6ca18b7f
Author: Nghia Nguyen <nednguyen@google.com>
Date: Thu Aug 09 16:52:56 2018

Status: Fixed (was: Assigned)
Project Member

Comment 30 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/765dd5f629199eef9e37bcfbf90e7785b106f673

commit 765dd5f629199eef9e37bcfbf90e7785b106f673
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri Aug 10 15:03:31 2018

Remove mention of BattOrs from perf trybot docs

TBR=nednguyen@chromium.org

Bug:  859514 
Change-Id: I5aa3aa1ca04eb69ddf3d9d28713df353f4f68b10
Reviewed-on: https://chromium-review.googlesource.com/1169440
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582164}
[modify] https://crrev.com/765dd5f629199eef9e37bcfbf90e7785b106f673/docs/speed/perf_trybots.md

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b170ec58e8db44797571af99d40f1868a31698db

commit b170ec58e8db44797571af99d40f1868a31698db
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri Aug 10 17:50:24 2018

Remove the (now-nonexistent) battor agent target from a whitelist

It looks like this file has * listed as its owner, so it doesn't need
any specific owner review.

Bug:  859514 
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: I9afd700a6a36f00b5fb46847fbc5d01d08646db8
Reviewed-on: https://chromium-review.googlesource.com/1169437
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#582236}
[modify] https://crrev.com/b170ec58e8db44797571af99d40f1868a31698db/build/check_gn_headers_whitelist.txt

Sign in to add a comment