CL authors need to have tryjob access to submit a CL |
||||||
Issue descriptionCurrently it seems CL authors need to have at least tryjob access to submit a CL through CQ even if they have an LGTM (see https://chromium-review.googlesource.com/c/v8/v8/+/1116551 as an example). AFAIK this was different in the past? If you have an LGTM, one could submit a CL anyway? Did anything change during the LUCI migration maybe?
,
Jul 2
,
Jul 2
,
Jul 2
And marking Untriaged to have it triaged by Foundation team.
,
Jul 2
,
Jul 2
This was a bit different in Rietveld, but current state is here since Gerrit migration in Feb 2017. See http://go/gerrit-cq-for-contributors which explains this in detail. This may be especially useful: https://bugs.chromium.org/p/chromium/issues/detail?id=692611#c5
,
Jul 3
Yea, this is WAI. If the contributor has no trybot access, someone else must land the CL for them. But regular contributors can just request trybot access...
,
Jul 9
Re #7: Where does a contributor request try-bot access? We should add this important piece of information to https://github.com/v8/v8/wiki/Contributing.
,
Jul 10
Chromium has a dedicated process for try-job-access here: https://www.chromium.org/getting-involved/become-a-committer Maybe we could mimic that? Anybody that has Chromium tryjob access has automatic access to V8 too. But not the other way around. So we'd need a process for sole V8 contributors that are not committers.
,
Jul 10
The easiest way might be to simply use the Chromium process anyway? |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by serg...@chromium.org
, Jul 2