New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859495 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 853794
issue 696597
issue 835234



Sign in to add a comment

Password generation blocks the credential dropdown for filling

Project Member Reported by battre@chromium.org, Jul 2

Issue description

If password generation is enabled and promoted for a site, this blocks the UI for manual filling on desktop. We should have a workaround for that.
 
Screenshot from 2018-07-17 21-33-52.png
22.1 KB View Download
Blocking: 696597
Cc: ioanap@chromium.org
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Summary: Password generation blocks the credential dropdown for filling (was: Password generation blocks manual fallback for filling)
Blocking: 853794
Blocking: 835234
The "Suggest strong password..." link is supposed to show on desktop platforms, not on Android. The password generation drop-down should not become visible on Android.

On Android, password generation is either available via a keyboard accessory button (automatic UI) or via they passwords bottom sheet (manual UI). Both entrypoints trigger a modal dialog.
Labels: -OS-Android
Labels: OS-Android
There is a bug on Android.
- if generation and accessory bar are DISABLED -> no bug obviously, only the drop-down appears.
- if generation enabled, accessory bar disabled -> my fix works exactly as on desktop. Clicking the menu item triggers the password generation drop-down.
- if both generation and accessory bar enabled -> bug, the password drop-down isn't shown at all for the new-password field.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2b64b9500baff6f24d69d91e7bcc6505a745dd

commit ff2b64b9500baff6f24d69d91e7bcc6505a745dd
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Jul 18 17:32:43 2018

Suppress the automatic generation for an ambiguous password field.

When there are saved credentials on the page we should suggest them on any
password field. If the field is eligible for generation we append it to the end
of the suggestions.
A screenshot is attached in the bug.

Bug:  859495 
Change-Id: I614faa89037074345794cd4107c8801f715142f4
Reviewed-on: https://chromium-review.googlesource.com/1140718
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576116}
[modify] https://crrev.com/ff2b64b9500baff6f24d69d91e7bcc6505a745dd/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/ff2b64b9500baff6f24d69d91e7bcc6505a745dd/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/ff2b64b9500baff6f24d69d91e7bcc6505a745dd/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/ff2b64b9500baff6f24d69d91e7bcc6505a745dd/components/autofill/core/browser/popup_item_ids.h
[modify] https://crrev.com/ff2b64b9500baff6f24d69d91e7bcc6505a745dd/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/ff2b64b9500baff6f24d69d91e7bcc6505a745dd/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/ff2b64b9500baff6f24d69d91e7bcc6505a745dd/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6f8ee1d9bddacd1df09ab038b021a3131393c0

commit 8c6f8ee1d9bddacd1df09ab038b021a3131393c0
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu Jul 19 19:26:54 2018

Display the credentials dropdown even when generation is offered

Offering automatic generation used to suppress the credentials
dropdown, since the generation popup would have overlapped the dropdown
or vice-versa. Since offering password generation is now done via the
keyboard accessory, this restriction is not needed anymore.

Bug:  859495 
Change-Id: I67e905aad0fcc262600d21cc87f087eef30ff314
Reviewed-on: https://chromium-review.googlesource.com/1143392
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576587}
[modify] https://crrev.com/8c6f8ee1d9bddacd1df09ab038b021a3131393c0/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/8c6f8ee1d9bddacd1df09ab038b021a3131393c0/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/8c6f8ee1d9bddacd1df09ab038b021a3131393c0/components/password_manager/core/browser/password_autofill_manager.h

Status: Fixed (was: Assigned)
Labels: Needs-Feedback
Tested this issue on Windows 10 and Mac OS 10.13.3 on the build without fix 69.0.3480.0 and unable to reproduce the issue by following the below steps.

1. Launched Chrome and enabled the flag #automatic-password-generation.
2. Saved username and password of facebook.com in chrome://settings/passwords.
3. navigated to facebook.com and could enter the password manually from keyboard and no 'Suggest strong password' dropdown is observed.
Attached is the screen cast for reference.

vasilii@ Request you to check and confirm if anything is missed from our end in verifying the issue?

Thanks..
859495.mp4
1.3 MB View Download
Are you sure you are signed-in to Chrome?
Can you trigger password generation on other sites or on this one without the credential saved? It seems that the feature is off for you.

Sign in to add a comment