Regression:Focus is not seen on the Actions icon after deleting entry from chrome://history
Reported by
vineetha...@etouch.net,
Jul 2
|
||
Issue descriptionChrome Version: 69.0.3479.0 (Official Build) Revision 4bd5a86d51d03f2c430547762c7a25a1a7946720-refs/branch-heads/3479@{#1}(32/64 bit) OS: Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) Pre-condition : Atleast one entry should be present under chrome://history What steps will reproduce the problem? (1) Launch Chrome navigate to chrome://history. (2) Press tab to get focus on the Actions icon for an entry and click to display the options. (3) Now click on 'Remove from history' and observe the focus. Actual Result : Focus is not seen on the Actions icon of the next entry in the history list. Expected Result: Once a history entry is deleted, focus should stay on the Actions icon of the next entry in the history list. This is regression issue broken in ‘M-68’, Good build: 68.0.3400.0(551876) Bad build : 68.0.3401.0(552221) Unable to provide bisect using per-revision script,hence re-bisected with old script: Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/e83aa862864a77b3f2a9109c92efed33943e98c9..9f7279479f4be59322d1e6146afe9200282887c5?pretty=fuller&n=10000 Suspect: r552149? @scottchen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b43103a71d955cf0d0fcad038a58617f4c33874 commit 5b43103a71d955cf0d0fcad038a58617f4c33874 Author: Scott Chen <scottchen@chromium.org> Date: Thu Jul 12 22:24:58 2018 History: fix list-item focus disappearing after delete Bug: 859489 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9d421d204c5023fa168ed89d4d8dd15564e03a03 Reviewed-on: https://chromium-review.googlesource.com/1122974 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#574752} [modify] https://crrev.com/5b43103a71d955cf0d0fcad038a58617f4c33874/chrome/browser/resources/md_history/history_list.html [modify] https://crrev.com/5b43103a71d955cf0d0fcad038a58617f4c33874/chrome/browser/resources/md_history/history_list.js
,
Jul 14
,
Jul 16
Update : Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04) OS with latest Canary Chrome version #69.0.3493.0 and the issue is still reproducible. Note: For the first time when a history entry is deleted, focus stay on the Actions icon of the next entry in the history list but for subsequent deletions focus is not seen on the Actions icon of the next entry in the history list. Kindly refer the attached screen cast. |
||
►
Sign in to add a comment |
||
Comment 1 by scottchen@chromium.org
, Jul 2