New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859487 link

Starred by 1 user
Status: Assigned
Owner:
creis@chromium.org
Cc:
█ nick@chromium.org
creis@chromium.org
alex...@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 2 
"RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxSZW5kZXJGcmFtZUhvc3RNYW5hZ2VyVGVzdC5BbGxvd1RhcmdldGVkTmF2aWdhdGlvbnNBZnRlclN3YXAM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by lucmult@chromium.org, Jul 3 

No idea why this test is marked as flaky... I couldn't find any related changes on the time frame where it started.

I'll disable and assign to some people that last touched this test/file.

Comment 2 by lucmult@chromium.org, Jul 3

Cc: creis@chromium.org alex...@chromium.org nick@chromium.org
Labels: -Sheriff-Chromium Test-Disabled
Owner: nasko@chromium.org
Status: Assigned (was: Untriaged)
CL below to disable, CCed a few other people from nasko@ and alexmos@ team since they seem to be OOO or soon to be OOO.

https://chromium-review.googlesource.com/c/chromium/src/+/1123999

Comment 3 by lucmult@chromium.org, Jul 3 

For future reference the failure is:

../../content/browser/frame_host/render_frame_host_manager_browsertest.cc(712): error: Value of: NavigateToURLInSameBrowsingInstance(new_shell, cross_site_url)
  Actual: false
Expected: true
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x01CA03E8+40]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x01CA8CF5+69]
	testing::internal::AssertHelper::operator= [0x01CA8940+48]
	content::RenderFrameHostManagerTest_AllowTargetedNavigationsAfterSwap_Test::RunTestOnMainThread [0x012F4BE2+2242]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0307B3F9+441]
	content::ShellBrowserMainParts::PreMainMessageLoopRun [0x039CC773+67]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x02038594+68]
	content::StartupTaskRunner::RunAllTasksNow [0x023A53BE+30]
	content::BrowserMainLoop::CreateStartupTasks [0x020374F5+805]
	content::BrowserMainRunnerImpl::Initialize [0x0203A93B+107]
	content::BrowserMainRunnerImpl::Initialize [0x0203A8B5+37]
	ShellBrowserMain [0x05CE650B+43]
	content::ShellMainDelegate::RunProcess [0x05CE5070+176]
	content::RunBrowserProcessMain [0x01F6EF13+83]
	content::ContentMainRunnerImpl::Run [0x01F6F7DB+459]
	service_manager::Main [0x035A690F+735]
	content::ContentMain [0x01F6EE63+51]
	content::BrowserTestBase::SetUp [0x0307B16E+1886]
../../content/browser/frame_host/render_frame_host_manager_browsertest.cc(714): error: Expected equality of these values:
  new_site_instance.get()
    Which is: 0CDCDC90
  new_shell->web_contents()->GetSiteInstance()
    Which is: 00DF2418
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x01CA03E8+40]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x01CA8CF5+69]
	testing::internal::AssertHelper::operator= [0x01CA8940+48]
	content::RenderFrameHostManagerTest_AllowTargetedNavigationsAfterSwap_Test::RunTestOnMainThread [0x012F4C98+2424]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0307B3F9+441]
	content::ShellBrowserMainParts::PreMainMessageLoopRun [0x039CC773+67]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x02038594+68]
	content::StartupTaskRunner::RunAllTasksNow [0x023A53BE+30]
	content::BrowserMainLoop::CreateStartupTasks [0x020374F5+805]
	content::BrowserMainRunnerImpl::Initialize [0x0203A93B+107]
	content::BrowserMainRunnerImpl::Initialize [0x0203A8B5+37]
	ShellBrowserMain [0x05CE650B+43]
	content::ShellMainDelegate::RunProcess [0x05CE5070+176]
	content::RunBrowserProcessMain [0x01F6EF13+83]
	content::ContentMainRunnerImpl::Run [0x01F6F7DB+459]
	service_manager::Main [0x035A690F+735]
	content::ContentMain [0x01F6EE63+51]
	content::BrowserTestBase::SetUp [0x0307B16E+1886]
[7596:10864:0702/110438.256:WARNING:discardable_shared_memory_manager.cc(431)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[  FAILED  ] RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap, where TypeParam =  and GetParam() =  (575 ms)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b06c3c60ad84db19b42e712494f5aedb775400a

commit 2b06c3c60ad84db19b42e712494f5aedb775400a
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Jul 03 04:41:03 2018

Disable flaky test AllowTargetedNavigationsAfterSwap

Test has been marked as flaky by Try-Flakes for different builders.


Tbr: nasko@chromium.org, alexmos@chromium.org
Bug: 859487
Change-Id: I39a8fd525a91b8bf6b6e4ab1b1c5c56ee0e38756
Reviewed-on: https://chromium-review.googlesource.com/1123999
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572108}
[modify] https://crrev.com/2b06c3c60ad84db19b42e712494f5aedb775400a/content/browser/frame_host/render_frame_host_manager_browsertest.cc

Comment 5 by nasko@chromium.org, Aug 27

Cc: nasko@chromium.org
Owner: creis@chromium.org
Assigning to creis@, who wrote the test a while ago and might have more knowledge of why it can be flaking now.
►

Sign in to add a comment