New issue
Advanced search Search tips

Issue 859481 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Mac][Flash] Unable to print through system dialog on next launch

Reported by xlro...@gmail.com, Jul 2

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Steps to reproduce the problem:
1. Install latest stable version of Chrome (i.e. 67.0.3396.99) on Mac machine (mine being macOS 10.13.4)
2. Before launching chrome, please make sure that local user-data for Chrome is clear ( i.e. delete/rename Chrome folder from here /Users/<user-name>/Library/Application Support/Google/ )
3. Launch Chrome and goto https://storyclassic.adobe.com
4. When asked, choose to allow flash player plugin to run on this site
5. Sign in with this dummy account (email: roverma+chrome@adobetest.com, password: Chrome@123)
6. After entering this credentials you will be on a page with loading animation. You will notice a prompt in the URL bar for flash plugin. Please do allow it to run on this page. Otherwise site won't load.
7. Once you are in, click on the 'PROJECTS' button and then double click on 'Paladin Script' to open that document
8. Once that document is successfully open, please choose 'Print' option from Application's 'File' menu (not the Chrome's one).
9. Click on 'OK' button in the subsequent dialog.
10. In the Chrome's print preview dialog, please choose 'Print using system dialog'
11. Click on 'PDF' dropdown in the next system dialog and choose 'Open in Preview'
12. At this step, PDF will open successfully in preview.
13. Close Preview and also completely quit Chrome (Cmd + Q)
14. Perform steps from #3 to #11 again.

What is the expected behavior?
Should be able to print through system dialog even on relaunch.

What went wrong?
On relaunch of Chrome, print through system dialog stops working.

Did this work before? Yes 66.0.3359.181

Chrome version: 67.0.3396.99  Channel: stable
OS Version: OS X 10.13.4
Flash Version: 30.0.0.113

This is working on Windows
 
ChromePrintIssue480p.mov
15.8 MB Download
Attached a screen capture of the steps in the comment above (file: ChromePrintIssue480p.mov)
Labels: Needs-Bisect Needs-Triage-M67
Cc: thestig@chromium.org creis@chromium.org alex...@chromium.org
Components: Internals>Printing Internals>Sandbox>SiteIsolation
Labels: -Pri-2 Pri-1
Owner: weili@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for the report!  I can confirm that "Open in Preview" doesn't work on Mac Stable 67.0.3396.99 for me when I followed your repro steps.  Starting with a fresh profile typically doesn't apply any field trials, which would be fetched and applied on next restart, so this is likely due to a field trial that was activated in M67.

I think this is related to site isolation.  I tried setting chrome://flags/#site-isolation-trial-opt-out to "Opt out", restarting, and repeating the repro steps, and "open the preview" started to work.  Can you confirm if setting this flag solves your issue?

weili@ or thestig@: would you be able to take a look?  There's an OOPIF as well as Flash on the page that's trying to print, and it seems something is going wrong with site isolation printing support.  This seems to occur regardless of whether chrome://flags/#use-pdf-compositor-service-for-print is enabled.

Labels: -Needs-Bisect -Needs-Triage-M67
I can reproduce this on Mac Canary without the need to relaunch. I don't think bisecting will find anything useful.
@alex: Thanks for the workaround. Yes. Setting this flag solves this issue.
I can turn off Print Preview altogether in Chromium and still reproduce this by going straight to the Mac native print dialog. So this isn't an issue in the Print Preview to system print dialog transition.

The error message I see in my debug build is PdfCompositorImpl::CompositeToPdf() failing with "No page is read" but I suspect the bigger problem is the code in the PDF compositor should not even be called in this case. Need to keep digging.
Cc: weili@chromium.org
Owner: thestig@chromium.org
PrintingPdfContent() from r542630 checks URLs, but that does not work for Flash content.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3764d52b7ff29111f5043e5efcfcc2e6d0ee6dba

commit 3764d52b7ff29111f5043e5efcfcc2e6d0ee6dba
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Jul 24 22:31:11 2018

Remove printing::PrintingPdfContent().

PrintingPdfContent() uses URLs to figure out if the content to be
printed is PDF or not. This does not work when printing Flash content.
Go back to checking PrintSettings::is_modifiable(), which already works
correctly on Mac. On Windows and Linux, the "is modifiable" setting
needs to be preserved when getting settings from the user in the native
print dialog.

BUG= 859481 

Change-Id: I674cf3c0f38b87c17fb6d2ca30ebae842c260d8c
Reviewed-on: https://chromium-review.googlesource.com/1146024
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577712}
[modify] https://crrev.com/3764d52b7ff29111f5043e5efcfcc2e6d0ee6dba/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/3764d52b7ff29111f5043e5efcfcc2e6d0ee6dba/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/3764d52b7ff29111f5043e5efcfcc2e6d0ee6dba/chrome/browser/printing/print_view_manager_common.h
[modify] https://crrev.com/3764d52b7ff29111f5043e5efcfcc2e6d0ee6dba/chrome/browser/ui/libgtkui/print_dialog_gtk.cc
[modify] https://crrev.com/3764d52b7ff29111f5043e5efcfcc2e6d0ee6dba/printing/printing_context_system_dialog_win.cc

Status: Fixed (was: Assigned)
Should be fixed in 70.0.3502.0 and newer.

I reproduced the same problem on Windows when Print Preview is disabled, BTW.
Labels: TE-Verified-M70 TE-Verified-70.0.3502.0
Able to reproduce this issue on Mac OS 10.13.3 on the reported version 67.0.3396.99 and the issue is fixed on the latest Canary 70.0.3502.0 as per the original comment.

Able to print through system dialog on relaunch.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
859481-M70.mp4
6.3 MB View Download

Sign in to add a comment