New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859472 link

Starred by 1 user
Status: Started
Owner:
battre@chromium.org
Cc:
█ nepper@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Password generation popup should hide after 1 character typed by the user

Project Member Reported by battre@chromium.org, Jul 2 
The password generation popup sometimes occludes the password requirements of a page. This is bad if a user wants to type a password themselves instead of relying on password generation.

As a work around, we want to hide the popup after the first typed character.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/147162d94c5c0345c803370caf32ebaebfb00773

commit 147162d94c5c0345c803370caf32ebaebfb00773
Author: Dominic Battre <battre@chromium.org>
Date: Tue Jul 03 06:56:02 2018

Introduce Finch parameter for hiding a password generation popup

If a user focuses a field for which password generation is promoted, a popup is
shown.

http://crrev.com/288935 introduced that this popup remains visible until the
user has typed 5 characters, hypothesizing that users look at their keyboard
while typing and therefore not notice the popup.

Our new hypothesis is that this a) may not be true, and b) may bother users
because the popup occludes part of the website, in particular it can occlude
password requirements for users who chose to invent their own password.

This CL introduces a Finch experiement such that we can test whether keeping the
popup visible until the user has typed >5 characters produces a statistically
significant higher number of generated passwords. If not, we can just hide the
password generation popup as soon as the user has typed a key.

The default configuration sticks to the 5 character threshold.

Bug: 859472
Change-Id: I1d2a82ce90f696dc32d97633ac29ba15f3ea9bbd
Reviewed-on: https://chromium-review.googlesource.com/1122399
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572131}
[modify] https://crrev.com/147162d94c5c0345c803370caf32ebaebfb00773/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/147162d94c5c0345c803370caf32ebaebfb00773/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/147162d94c5c0345c803370caf32ebaebfb00773/components/autofill/content/renderer/password_generation_agent.h
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74d03b21862c510c4be73100103b343f87dbc7a5

commit 74d03b21862c510c4be73100103b343f87dbc7a5
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Aug 09 13:24:52 2018

Set the minimum length of the generated password to 4.

Dismiss the generation prompt when > 5 characters typed.

Bug:  869890 ,859472
Change-Id: Ib842b92857a79e92e411e7247ad0cc4a322dd364
Reviewed-on: https://chromium-review.googlesource.com/1167507
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581885}
[modify] https://crrev.com/74d03b21862c510c4be73100103b343f87dbc7a5/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/74d03b21862c510c4be73100103b343f87dbc7a5/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/74d03b21862c510c4be73100103b343f87dbc7a5/components/autofill/content/renderer/password_generation_agent.h
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddadbcabbd6f3e27c424c55cbb55bbd2060ace21

commit ddadbcabbd6f3e27c424c55cbb55bbd2060ace21
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Aug 13 08:54:50 2018

Set the minimum length of the generated password to 4.

Dismiss the generation prompt when > 5 characters typed.

TBR=vasilii@chromium.org

(cherry picked from commit 74d03b21862c510c4be73100103b343f87dbc7a5)

Bug:  869890 ,859472
Change-Id: Ib842b92857a79e92e411e7247ad0cc4a322dd364
Reviewed-on: https://chromium-review.googlesource.com/1167507
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581885}
Reviewed-on: https://chromium-review.googlesource.com/1172286
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#561}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/ddadbcabbd6f3e27c424c55cbb55bbd2060ace21/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/ddadbcabbd6f3e27c424c55cbb55bbd2060ace21/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/ddadbcabbd6f3e27c424c55cbb55bbd2060ace21/components/autofill/content/renderer/password_generation_agent.h
►

Sign in to add a comment