I have a CL in review to fix, thanks for reporting.

Thanks! The 1st issue got fixed. But the 2nd is still there.

Which part of the cancel function do you need to have called? Escape is currently handled on the c++ side.

Basically I want to cancel calls to Active Directory daemon (https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc?rcl=daa7d423b2673406ac6b285cf7e2882fd9e92517&l=727)

Thanks, I'll take a look at fixing.

https://chromium-review.googlesource.com/c/chromium/src/+/1123307 will make escape go through the same code path as hitting the back button.

From my understanding the login architecture, gaia_screen_handler (all the *_handler) classes are meant to be specific to webui, and some other type which interacts with gaia_view should be the one implementing active-directory logic. That cleanup can happen another time, though.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a807b9f90d639d1c036f3c68ae5845cdbab51f

commit 22a807b9f90d639d1c036f3c68ae5845cdbab51f
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Jul 06 21:01:24 2018

cros: Forward escape accelerator to oobe dialog in views login.

There is some active directory logic in GaiaScreenHandler that should run
whenever gaia is cancelled. This is the easiest way to run that logic. Long-term
the active directory logic should be refactored outside of GaiaScreenHandler,
since GaiaScreenHandler should only contain webui-specific code, and the active
directory code is UI agnostic.

Bug:  859470 
Change-Id: Ibd203b1ec5da07a721a749a569e6f4cb848b7025
Reviewed-on: https://chromium-review.googlesource.com/1123307
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573069}
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/login_display_host_common.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/22a807b9f90d639d1c036f3c68ae5845cdbab51f/ui/login/display_manager.js

I was able to reproduce this using 10836.0.0, 69.0.3479.0 and verify using 10872.0.0, 69.0.3488.0 (Santa). X-button and ESC button now close the Sign-in window.