New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859440 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Overscroll action is positioned too high on NTP

Project Member Reported by gambard@chromium.org, Jul 2

Issue description

With UI Refres enabled, on iPhone

What steps will reproduce the problem?
(1) Open NTP
(2) Trigger overscroll

What is the expected result?
The overscroll actions should be correctly positioned.

What happens instead?
The overscroll actions are shown too high, below the status bar.
 
Labels: M-69
Labels: zine-triaged
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0007b289fa6da0cd6b0b5f173fbac8ebcbd2bb

commit fa0007b289fa6da0cd6b0b5f173fbac8ebcbd2bb
Author: Justin Cohen <justincohen@google.com>
Date: Tue Jul 17 11:55:48 2018

[ios] Fix overscroll target for NTP.

Bug:  859440 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I28b4542d8752d3c8ee52f62aa2894dabf787a0d7
Reviewed-on: https://chromium-review.googlesource.com/1139606
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575606}
[modify] https://crrev.com/fa0007b289fa6da0cd6b0b5f173fbac8ebcbd2bb/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/fa0007b289fa6da0cd6b0b5f173fbac8ebcbd2bb/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on M70.0.3501.0 canary
Device: iPhoneSE, iPhone7Plus, iPhoneX
iOS: 11.4.1, 10.3.3, 12.0 beta#4

Sign in to add a comment