New issue
Advanced search Search tips

Issue 859427 link

Starred by 2 users
Status: WontFix
Owner:
qyears...@chromium.org
Closed: Jul 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect "found trailing space" report from tricium

Project Member Reported by ekempin@google.com, Jul 2 
What steps will reproduce the problem?
(1) https://gerrit-review.googlesource.com/c/gerrit/+/186971/6/Documentation/rest-api-changes.txt

What is the expected result?
There are no trailing spaces in this file, so there should be no report

What happens instead?
It's reporting "found trailing space" as a file comment.

Please provide any additional information below.

Clicking "not useful" didn't work for an external contributor (david.pursehouse@gmail.com), see https://bugs.chromium.org/p/gerrit/issues/detail?id=9371, but it did work for me.

This bug was originally files as https://bugs.chromium.org/p/gerrit/issues/detail?id=9371.

Comment 1 by qyears...@chromium.org, Jul 2

Cc: -qyearsley@google.com
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
Thanks for filing. Looking at that CL, there appears to be trailing space on line 6793, which is what spacey found:
https://chromium-swarm.appspot.com/task?id=3e70696d42632c10&refresh=10&show_raw=1

So, I think there are two issues:

 1. The comment is a file level comment. This is  bug 853887 , a fix is being deployed and tested today.

 2. Clicking not useful didn't work for an external contributor. Filed bug 859576 for this.

Comment 2 by qyears...@chromium.org, Jul 6

Status: WontFix (was: Assigned)
Closing this since I thin it's covered by the two issues noted above.

Comment 3 by ekempin@google.com, Jul 9 

Thanks for looking into this.
►

Sign in to add a comment