New issue
Advanced search Search tips

Issue 859415 link

Starred by 1 user
Status: Fixed
Owner:
shimazu@chromium.org
Closed: Jul 4
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ServiceWorkerNavigationLoader::Cancel doesn't delete the object and it leaks

Project Member Reported by shimazu@chromium.org, Jul 2 
DeleteIfNeeded reads binding_.is_valid() but it looks true until binding_.Close() is called.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32e7554880f1b157bfcd5d419c7a0ee8fc1c7dee

commit 32e7554880f1b157bfcd5d419c7a0ee8fc1c7dee
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jul 03 08:56:39 2018

Fix leak when ServiceWorkerNavigationLoader forwards request to SW

Previously SWNavigationLoader::Cancel() didn't clear |binding_| and it didn't
delete itself. This CL is to close the binding explicitly and fixes the leak.

Bug:  859415 
Change-Id: I99a79f2f0cc21802bdd36d507c4c8692955cc3d9
Reviewed-on: https://chromium-review.googlesource.com/1122065
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572153}
[modify] https://crrev.com/32e7554880f1b157bfcd5d419c7a0ee8fc1c7dee/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/32e7554880f1b157bfcd5d419c7a0ee8fc1c7dee/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/32e7554880f1b157bfcd5d419c7a0ee8fc1c7dee/content/browser/service_worker/service_worker_navigation_loader_unittest.cc

Comment 2 by shimazu@chromium.org, Jul 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment