Dragging key in right-top corner not works with floating window |
|||||
Issue description69.0.3476.0 Link 10833.0.0 canary link Input tools version: 69.0.5.0 Steps: 1.Switch to any keyboard floating window 2.Pressing down right-top corner key in floating window to drag it Actual: have no response
,
Jul 11
Hi Yingbing, I fixed the dragging bug in https://chromium-review.googlesource.com/c/chromium/src/+/1114562. Dragging works with the old UI. I'll check why it doesn't work with new UI.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f10ba6b2e7f231a2ec6fb549f1b470da3f17a2 commit e5f10ba6b2e7f231a2ec6fb549f1b470da3f17a2 Author: Darren Shen <shend@chromium.org> Date: Thu Jul 12 01:22:39 2018 [VK] Swap top/left in parsing SetDraggableArea arguments. 'x' was mistakenly matched with 'top' and 'y' with 'left'. Should be the other way around. The old UI worked because x and y were the same (0, 0), but that's no longer true with the new UI. TBR=blakeo@chromium.org Bug: 859405 , 856475 Test: Manual Change-Id: I3ac31c4386abb7f86d850fea25ffb543419cf287 Reviewed-on: https://chromium-review.googlesource.com/1133601 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#574444} [modify] https://crrev.com/e5f10ba6b2e7f231a2ec6fb549f1b470da3f17a2/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
,
Jul 13
,
Jul 13
We still cannot drag if floating keyboard shows for the first time. As discussed offline with wuyingbing@, we should wait until we move the drag handle according to the new UI.
,
Jul 16
Please verify after 17 July
,
Jul 17
Partly fixed; Still repro when switch between with A11y & Input view layout for first dragging ;
,
Jul 19
please verify in next version.
,
Jul 19
Verified in 69.0.3494.0 10888.0.0 canary-channel bob Input tools version: 9999.0.20180715.2046765f58 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wuyingbing@chromium.org
, Jul 11