New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859364 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Net.CertificateTransparency.MainFrameValidSCTCount doesn't work with the network service enabled.

Project Member Reported by mmenke@chromium.org, Jul 1

Issue description

Net.CertificateTransparency.MainFrameValidSCTCount is only recorded in ResoruceDispatcherHostImpl, which isn't used when the network service is enabled.  I believe it can just be hooked up in 
content/browser/loader/navigation_url_loader_impl.cc to cover both the network service and legacy paths.

I don't think this should block experiments on Canary with the network service, though could be wrong.  I do believe it should block a 100% rollout on Canary.
 
Cc: est...@chromium.org
Labels: -Pri-3 Proj-Servicification-Canary Hotlist-KnownIssue Pri-2
Status: Available (was: Untriaged)
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: mmenke@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9cad56fca85981a14b10d32acd4e7039d0d368d

commit d9cad56fca85981a14b10d32acd4e7039d0d368d
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Aug 10 21:47:09 2018

Make cert transparency histogram work with the NetworkService.

In particular, move Net.CertificateTransparency.MainFrameValidSCTCount
from ResourceDispatcherHost to NavigationURLLoaderImpl.

Bug:  859364 
Change-Id: I2258fc36af30b64b76eb7c5bc2c1f9851bb0f1be
Reviewed-on: https://chromium-review.googlesource.com/1168093
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582349}
[modify] https://crrev.com/d9cad56fca85981a14b10d32acd4e7039d0d368d/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/d9cad56fca85981a14b10d32acd4e7039d0d368d/content/browser/loader/resource_dispatcher_host_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment