Net.CertificateTransparency.MainFrameValidSCTCount doesn't work with the network service enabled. |
|||||
Issue descriptionNet.CertificateTransparency.MainFrameValidSCTCount is only recorded in ResoruceDispatcherHostImpl, which isn't used when the network service is enabled. I believe it can just be hooked up in content/browser/loader/navigation_url_loader_impl.cc to cover both the network service and legacy paths. I don't think this should block experiments on Canary with the network service, though could be wrong. I do believe it should block a 100% rollout on Canary.
,
Jul 11
,
Jul 12
,
Aug 8
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9cad56fca85981a14b10d32acd4e7039d0d368d commit d9cad56fca85981a14b10d32acd4e7039d0d368d Author: Matt Menke <mmenke@chromium.org> Date: Fri Aug 10 21:47:09 2018 Make cert transparency histogram work with the NetworkService. In particular, move Net.CertificateTransparency.MainFrameValidSCTCount from ResourceDispatcherHost to NavigationURLLoaderImpl. Bug: 859364 Change-Id: I2258fc36af30b64b76eb7c5bc2c1f9851bb0f1be Reviewed-on: https://chromium-review.googlesource.com/1168093 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582349} [modify] https://crrev.com/d9cad56fca85981a14b10d32acd4e7039d0d368d/content/browser/loader/navigation_url_loader_impl.cc [modify] https://crrev.com/d9cad56fca85981a14b10d32acd4e7039d0d368d/content/browser/loader/resource_dispatcher_host_impl.cc
,
Aug 10
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rsleevi@chromium.org
, Jul 2