New issue
Advanced search Search tips

Issue 859317 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ImageWriterWriteFromUrlOperationTest.SelectTargetWithExtension" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 30 2018

Issue description

"ImageWriterWriteFromUrlOperationTest.SelectTargetWithExtension" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5JbWFnZVdyaXRlcldyaXRlRnJvbVVybE9wZXJhdGlvblRlc3QuU2VsZWN0VGFyZ2V0V2l0aEV4dGVuc2lvbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Sample failing log for future reference.
ImageWriterWriteFromUrlOperationTest.SelectTargetWithExtension.log
216 KB View Download
Cc: karandeepb@chromium.org lazyboy@chromium.org
Owner: rdevlin....@chromium.org
The following tests are flaky on TSan:

ImageWriterWriteFromUrlOperationTest.SelectTargetWithExtension 
ImageWriterWriteFromUrlOperationTest.SelectTargetWithoutExtension

The error logs says "data race" and seem to be triggered on the test destructor.

I'm disabling this test for TSan.


ImageWriterWriteFromUrlOperationTest.SelectTargetWithoutExtension.txt
217 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/401e3d2678e9df81eb1e6302d3eede3aa2adc06e

commit 401e3d2678e9df81eb1e6302d3eede3aa2adc06e
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Mon Jul 02 04:45:30 2018

Disable flaky tests from ImageWriterWriteFromUrlOperationTest

The following tests have been failing on TSan builder:
ImageWriterWriteFromUrlOperationTest.SelectTargetWithExtension
ImageWriterWriteFromUrlOperationTest.SelectTargetWithoutExtension

Tbr: rdevlin.cronin@chromium.org
Bug: 859317
Change-Id: Ic75ece0e4cb2121220f490a24850da866d721f9c
Reviewed-on: https://chromium-review.googlesource.com/1121996
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571818}
[modify] https://crrev.com/401e3d2678e9df81eb1e6302d3eede3aa2adc06e/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc

Labels: -Sheriff-Chromium
Labels: Test-Disabled
 Issue 859207  has been merged into this issue.
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment