New issue
Advanced search Search tips

Issue 859316 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 841643



Sign in to add a comment

Clicking bubble close button temporarily draws main window as inactive

Project Member Reported by pkasting@chromium.org, Jun 30 2018

Issue description

Force Chrome to crash so it shows the "Restore pages?" bubble on startup.  Restart Chrome so this bubble is showing.  Hold the mouse button down on the close X for the bubble.  The main window frame draws as inactive.

This looks really bad in Refresh since in this case the default is to start with just one new tab, thus putting us in single-tab mode, and the activation change drops out of single-tab mode, so the whole frame changes color.  Thus closing the bubble makes the frame flicker.

The frame already has a concept of ShouldPaintAsActive() that can return true even when the frame is not active, so hopefully it's possible to somehow figure out that we should paint as active when one of our bubble widgets is activated?
 
I'll take a look. Weirdly, it seems like ONLY the "restore pages" bubble does this, so I'm guessing there's something weird with that one instead of there being a general problem.
Labels: Group-Window_Frame
Is this a regression from M67 non-MdRefresh?
Didn't check, but it's definitely much more noticeable with single-tab mode in any case.
#3: No. I'm waiting to actually look at this for the single-tab mode cut decision.
Labels: -Pri-2 Pri-3
Lowering priority since this is not a regression and single-tab mode is no longer in scope.
Labels: M-70 Target-70
Labels: -M-70 -Target-70 M-71 Target-71
Labels: -Proj-MdRefresh Proj-DesktopUI
Labels: Hotlist-DesktopUITriaged
Cc: viswa.karala@chromium.org
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
** UI Mass Triage ** 

Adding appropriate label for expert review.

Thanks!
Labels: -M-71 -Target-71 M-73 Target-73

Sign in to add a comment