New issue
Advanced search Search tips

Issue 859314 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Jul 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in get

Project Member Reported by ClusterFuzz, Jun 30 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6427573131935744

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  get
  Impl
  GetHash
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=570731:570732

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6427573131935744

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 30 2018

Components: Blink>Internals>WTF Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 30 2018

Labels: Test-Predator-Auto-Owner
Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/cbf76818d0f7e88d489f18ada04a4077e594daec (Roll clang 335091:335608.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by thakis@chromium.org, Jun 30 2018

Labels: Test-Predator-Wrong-CLs
Status: Untriaged (was: Assigned)
It's possible this is due to the compiler run, but then that very likely only exposes existing undefined behavior.
Labels: M-69 Test-Predator-Wrong CF-NeedsTriage
Unable to provide possible suspect using Predator, CL and Code Search.
Could someone please look into the issue.
Thank You.
Components: -Internals>Core -Blink>Internals>WTF Blink>Loader
Labels: Test-Predator-Wrong-Components
Owner: ----
It's likely that ResourceFetcher has put a null String to HashMap as a key.
Status: Available (was: Untriaged)
Simple repro steps:

1. Open data:text/xml,<%3Fxml-stylesheet%20%3F>
2. Open devtools
Components: -Blink>Loader Platform>DevTools
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/chromium/src/+/1132914
Components: -Platform>DevTools Blink>Loader
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae18f0f47b8272cc5b911cc22cb799a648405f45

commit ae18f0f47b8272cc5b911cc22cb799a648405f45
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Jul 12 04:26:33 2018

Fix crash in ResourceFetcher::CachedResource()

This fixes a bug where ResourceFetcher::CachedResource() crashes when
given a null KURL.

Bug:  859314 
Change-Id: Iae07ded3124b690854aa7ba2a532f21be2a99972
Reviewed-on: https://chromium-review.googlesource.com/1132914
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574487}
[modify] https://crrev.com/ae18f0f47b8272cc5b911cc22cb799a648405f45/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/ae18f0f47b8272cc5b911cc22cb799a648405f45/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc

Status: Fixed (was: Started)
Project Member

Comment 11 by ClusterFuzz, Jul 12

ClusterFuzz has detected this issue as fixed in range 574486:574487.

Detailed report: https://clusterfuzz.com/testcase?key=6427573131935744

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  get
  Impl
  GetHash
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=570731:570732
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=574486:574487

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6427573131935744

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jul 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6427573131935744 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment