New issue
Advanced search Search tips

Issue 859304 link

Starred by 2 users
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Jul 2
Cc:
pdr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 856808



Sign in to add a comment

virtual/threaded/animations/cancel-unattached-animation.html has gone flaky

Project Member Reported by pdr@chromium.org, Jun 30 2018 
This test now passes and crashes on almost every run:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=virtual%2Fthreaded%2Fanimations%2Fcancel-unattached-animation.html

First crash occurred at r571725 which is right after https://crrev.com/571724 landed.
https://crrev.com/571724: [Fast compositing] Don't set any compositing reasons for non-self-painting PaintLayers.

Crash stack:
STDERR: [1:1:0630/094921.181468:FATAL:compositing_requirements_updater.cc(252)] Check failed: !cur_layer->DirectCompositingReasons() || !layer->Compositor()->CanBeComposited(cur_layer). 
#0 base::debug::StackTrace::StackTrace()
#1 logging::LogMessage::~LogMessage()
#2 blink::CheckSubtreeHasNoCompositing()
#3 blink::CheckSubtreeHasNoCompositing()
#4 blink::CompositingRequirementsUpdater::UpdateRecursive()
#5 blink::CompositingRequirementsUpdater::Update()
#6 blink::PaintLayerCompositor::UpdateIfNeeded()
#7 blink::PaintLayerCompositor::UpdateIfNeededRecursiveInternal()
#8 blink::PaintLayerCompositor::UpdateIfNeededRecursiveInternal()
#9 blink::PaintLayerCompositor::UpdateIfNeededRecursive()
#10 blink::LocalFrameView::UpdateLifecyclePhasesInternal()
#11 blink::LocalFrameView::UpdateAllLifecyclePhases()

Comment 1 by kbr@chromium.org, Jul 1

Labels: -Pri-2 Pri-1
This flaky crash is affecting the commit queue badly. On linux_chromium_rel_ng:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng?limit=200

most try jobs fail this test. Some of them retry it, but because the crash is flaky it's not guaranteed that the retry will fail like the original job did. For example in this try job:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/131166

The test passed in the retry, so the tryjob failed.

Reverting https://chromium-review.googlesource.com/1119584 because it sounds like it has introduced a logic error which is unfortunately only caught on the commit queue because DCHECKs aren't turned on on the waterfall's Release bots.

Comment 2 by kbr@chromium.org, Jul 1 

Snapshot of linux_chromium_rel_ng's current status.
Screen Shot 2018-07-01 at 2.50.07 PM.png
918 KB View Download

Comment 3 by kbr@chromium.org, Jul 1 

 Issue 859323  has been merged into this issue.

Comment 4 by kbr@chromium.org, Jul 1

Blocking: 856808
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Jul 2

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "virtual/threaded/animations/cancel-unattached-animation.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjx2aXJ0dWFsL3RocmVhZGVkL2FuaW1hdGlvbnMvY2FuY2VsLXVuYXR0YWNoZWQtYW5pbWF0aW9uLmh0bWwM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a41279aa8c63eb6ddc8c032223fe7bf3498949b

commit 1a41279aa8c63eb6ddc8c032223fe7bf3498949b
Author: Kenneth Russell <kbr@chromium.org>
Date: Mon Jul 02 00:54:41 2018

Revert "[Fast compositing] Don't set any compositing reasons for non-self-painting PaintLayers."

This reverts commit 655a604ce836d960d0a9cea12422b35276b4a769.

Reason for revert: caused intermittent crashes in layout tests, cancel-unattached-animation.html in particular. The logic error seems significant enough to warrant reverting.

Bug:  859304 

Original change's description:
> [Fast compositing] Don't set any compositing reasons for non-self-painting PaintLayers.
> 
> They can't composite anyway.
> 
> Bug:  856808 
> 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ie7071658827b7bc23315db775c7d872817190fb4
> Reviewed-on: https://chromium-review.googlesource.com/1119584
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571724}

TBR=trchen@chromium.org,pdr@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  856808 
Change-Id: I4147f27c73af71751bbd3bddd852bd858c82c5b6
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1121856
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571801}
[modify] https://crrev.com/1a41279aa8c63eb6ddc8c032223fe7bf3498949b/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc
[modify] https://crrev.com/1a41279aa8c63eb6ddc8c032223fe7bf3498949b/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
[modify] https://crrev.com/1a41279aa8c63eb6ddc8c032223fe7bf3498949b/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater_test.cc
[modify] https://crrev.com/1a41279aa8c63eb6ddc8c032223fe7bf3498949b/third_party/blink/renderer/core/paint/paint_layer_test.cc

Comment 8 by lucmult@chromium.org, Jul 2

Labels: -Sheriff-Chromium
removing from sheriff queue/label, since the revert seems to have fixed the flakiness.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a8a4289a2c97fa6442c945621480dc18a3fb9b

commit f0a8a4289a2c97fa6442c945621480dc18a3fb9b
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Mon Jul 02 21:22:38 2018

Re-land: [Fast compositing] Don't set any compositing reasons for non-self-painting PaintLayers.

This reverts commit 1a41279aa8c63eb6ddc8c032223fe7bf3498949b.

virtual/threaded/animations/cancel-unattached-animation.html was failing because
PaintLayerCompositor::CanBeComposited has an early out if the LocalFrameView's IsVisible
bit is false. When that bit changes, compositing inputs need to re-computed, to get a correct
value for PaintLayer::DescendantHasDirectOrScrollingCompositingReason.

Bug:  859304 , 856808 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4eb61112f3d396df1361486007c6efd2c6f7b339
Reviewed-on: https://chromium-review.googlesource.com/1123027
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572002}
[modify] https://crrev.com/f0a8a4289a2c97fa6442c945621480dc18a3fb9b/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/f0a8a4289a2c97fa6442c945621480dc18a3fb9b/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/f0a8a4289a2c97fa6442c945621480dc18a3fb9b/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc
[modify] https://crrev.com/f0a8a4289a2c97fa6442c945621480dc18a3fb9b/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
[modify] https://crrev.com/f0a8a4289a2c97fa6442c945621480dc18a3fb9b/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater_test.cc
[modify] https://crrev.com/f0a8a4289a2c97fa6442c945621480dc18a3fb9b/third_party/blink/renderer/core/paint/paint_layer_test.cc

Comment 10 by chrishtr@chromium.org, Jul 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment