Detected 3 new flakes for test/step "org.chromium.chrome.browser.contextual_suggestions.ContextualSuggestionsTest#testScrollPageToTrigger". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybwsSBUZsYWtlImRvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuY29udGV4dHVhbF9zdWdnZXN0aW9ucy5Db250ZXh0dWFsU3VnZ2VzdGlvbnNUZXN0I3Rlc3RTY3JvbGxQYWdlVG9UcmlnZ2VyDA. This message was posted automatically by the chromium-try-flakes app.

Test is flaky, failing with the following message:
"java.util.concurrent.TimeoutException: waitForCallback timed out!"

I'm disabling and assigning to test creator.

Attaching flakiness dashboard screenshot and test logs for future reference.

Deleted: contextual_suggestions.ContextualSuggestionsTest_testScrollPageToTrigger.log 13.4 KB

contextual_suggestions.ContextualSuggestionsTest_testScrollPageToTrigger.log 13.4 KB View Download

Deleted: Screen Shot 2018-07-02 at 3.23.23 PM.png 290 KB

	Screen Shot 2018-07-02 at 3.23.23 PM.png 290 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41831441afae6bb078f25255f77898b32e666ae

commit e41831441afae6bb078f25255f77898b32e666ae
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Mon Jul 02 06:32:29 2018

Disable flaky tests from ContextualSuggestionsTest

ContextualSuggestionsTest#testScrollPageToTrigger test has been flaky.

Tbr: twellington@chromium.org
Bug:  859292 
Change-Id: I3b6cc237c1771edeff12bbe19c1a85cd8797ef38
Reviewed-on: https://chromium-review.googlesource.com/1121997
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571824}
[modify] https://crrev.com/e41831441afae6bb078f25255f77898b32e666ae/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java

It looks like there was a single try flake on 05/21 then this became much more flaky on 6/29. I suspect that my recent changes to start adding to the toolbar button are likely to blame.

Dropping to a P2 since this test is disabled and we're moving away from showing EoC on reverse scroll.

Trace:
java.util.concurrent.TimeoutException: waitForCallback timed out!
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191)
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:227)
	at org.chromium.chrome.browser.contextual_suggestions.ContextualSuggestionsTest.testScrollPageToTrigger(ContextualSuggestionsTest.java:245)
	at java.lang.reflect.Method.invokeNative(Method.java)
	at java.lang.reflect.Method.invoke(Method.java:515)


It looks like the fully peeked signal isn't getting reliably sent based on the line number: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java?q=ContextualSuggestionsTest&sq=package:chromium&dr=CSs&l=247

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba455a15dbfb3cb4491f5b6b120b2afc72b46110

commit ba455a15dbfb3cb4491f5b6b120b2afc72b46110
Author: Theresa <twellington@chromium.org>
Date: Sat Sep 22 00:09:42 2018

[EoC] Remove support for reverse scroll triggering

We're no longer experimenting with reverse scroll triggering, so remove
support for:
 - reverse scroll triggering
 - slim peek
 - peek conditions (apart from delay, which we may use later)

BUG= 859292 , 876943 ,885331

Change-Id: Ibe962d6ece4340eb7b57784bbe078cc0847de728
Reviewed-on: https://chromium-review.googlesource.com/1236453
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593386}
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/res/layout/contextual_suggestions_toolbar.xml
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContentCoordinator.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsBottomSheetContent.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsCoordinator.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsMediator.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsModel.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/FetchHelper.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ToolbarView.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ToolbarViewBinder.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/EnabledStateMonitorTest.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/android/junit/src/org/chromium/chrome/browser/contextual_suggestions/FetchHelperTest.java
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/browser/about_flags.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/chrome/browser/ui/webui/eoc_internals/eoc_internals_page_handler.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/components/ntp_snippets/contextual/contextual_suggestions_features.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/components/ntp_snippets/contextual/contextual_suggestions_features.h
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/components/ntp_snippets/contextual/contextual_suggestions_fetch.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/components/ntp_snippets/contextual/contextual_suggestions_fetch_unittest.cc
[modify] https://crrev.com/ba455a15dbfb3cb4491f5b6b120b2afc72b46110/testing/variations/fieldtrial_testing_config.json

Fixed by removing the test