New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859269 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

accessory signing should not need a new copy/paste script per device

Project Member Reported by nsanders@chromium.org, Jun 30 2018

Issue description

It looks like the signer setup for accessories
src/platform/vboot_reference/scripts/keygeneration/accessory
requires adding new build infra per board.

If wen intend to scale devices with accessories, one accessory signer script that could be reused is needed.
 
Owner: nsanders@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/ebc8bb5fc79a0c3244df8650f162c3a94b62d0f7

commit ebc8bb5fc79a0c3244df8650f162c3a94b62d0f7
Author: Nick Sanders <nsanders@chromium.org>
Date: Mon Sep 10 20:33:45 2018

accessory: script to generically generate accessory keys

All accessories leverage the key format of Hammer therefore this
script calls Hammer's one to generate a key pair and renames them.
The key name isn't referenced by the signer anymore, so we will
name them all "hammerlike".

BUG= chromium:859269 
TEST=Run this script in the chroot.
BRANCH=None

Change-Id: Iba35b03e59216e96a99f8aa471b660f3805c1f23
Reviewed-on: https://chromium-review.googlesource.com/1205636
Commit-Ready: Nick Sanders <nsanders@chromium.org>
Tested-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: Marco Chen <marcochen@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/fe6d3ddf1aed16d0708f9f4d2e0aecf8eac05994/scripts/keygeneration/accessory/create_new_nocturne-fp_keys.sh
[delete] https://crrev.com/fe6d3ddf1aed16d0708f9f4d2e0aecf8eac05994/scripts/keygeneration/accessory/create_new_staff_keys.sh
[delete] https://crrev.com/fe6d3ddf1aed16d0708f9f4d2e0aecf8eac05994/scripts/keygeneration/accessory/create_new_wand.keys.sh
[delete] https://crrev.com/fe6d3ddf1aed16d0708f9f4d2e0aecf8eac05994/scripts/keygeneration/accessory/create_new_whiskers_keys.sh
[rename] https://crrev.com/ebc8bb5fc79a0c3244df8650f162c3a94b62d0f7/scripts/keygeneration/accessory/create_new_hammer_like_keys.sh
[delete] https://crrev.com/fe6d3ddf1aed16d0708f9f4d2e0aecf8eac05994/scripts/keygeneration/accessory/create_new_hammer_keys.sh

Status: Fixed (was: Untriaged)
thanks for the help here

Sign in to add a comment