New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859251 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Benchmark upload fails with KeyError

Project Member Reported by nednguyen@chromium.org, Jun 30 2018

Issue description

https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2Fmac-10_13_laptop_high_end-perf%2F183%2F%2B%2Frecipes%2Fsteps%2Fperformance_test_suite_on_ATI_GPU_on_Mac%2F0%2Flogs%2FMerge_script_log%2F0

Traceback (most recent call last):
  File "/b/c/b/mac_10_13_laptop_high_end_perf/src/tools/perf/process_perf_results.py", line 469, in <module>
    sys.exit(main())
  File "/b/c/b/mac_10_13_laptop_high_end_perf/src/tools/perf/process_perf_results.py", line 465, in main
    args.smoke_test_mode)
  File "/b/c/b/mac_10_13_laptop_high_end_perf/src/tools/perf/process_perf_results.py", line 276, in _process_perf_results
    configuration_name, build_properties, service_account_file, extra_links)
  File "/b/c/b/mac_10_13_laptop_high_end_perf/src/tools/perf/process_perf_results.py", line 347, in _handle_perf_results
    if not benchmark_enabled_map[benchmark_name]:
KeyError: 'smoothness.tough_canvas_cases.reference'
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b355d1423df6aef80c9a761173f22ccae8c29ad

commit 7b355d1423df6aef80c9a761173f22ccae8c29ad
Author: Ned Nguyen <nednguyen@google.com>
Date: Sat Jun 30 01:09:33 2018

Make benchmark_enabled_map key look-up returns False if key not found

NOTRY=true  # this does not have unittest
TBR=eyaich@chromium.org

Bug:  859251 
Change-Id: Ic3da603cb16b5d41ecc2368ff7492735ec26e147
Reviewed-on: https://chromium-review.googlesource.com/1121519
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571729}
[modify] https://crrev.com/7b355d1423df6aef80c9a761173f22ccae8c29ad/tools/perf/process_perf_results.py

Status: Fixed (was: Untriaged)

Sign in to add a comment