New issue
Advanced search Search tips

Issue 859241 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 825890



Sign in to add a comment

Fullscreen webapps should be able to control cutout

Project Member Reported by beccahughes@chromium.org, Jun 30 2018

Issue description

Fullscreen webapps are fullscreen so they should be able to control the cutout
 
Components: -Blink>Layout
Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8633462d2d7702777c674e3d040a2001bd763b37

commit 8633462d2d7702777c674e3d040a2001bd763b37
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jul 09 21:29:38 2018

[Display Cutout] Do not create DisplayCutoutHostImpl

Do not create DisplayCutoutHostImpl automatically in WebContentsImpl

BUG= 859241 

Change-Id: I1dff20d653d1712f529f595c3fb9d0ce08eaceeb
Reviewed-on: https://chromium-review.googlesource.com/1129557
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573451}
[modify] https://crrev.com/8633462d2d7702777c674e3d040a2001bd763b37/content/browser/web_contents/web_contents_impl.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bda2c4df785721b35cdf789f89d6a3291a97a889

commit bda2c4df785721b35cdf789f89d6a3291a97a889
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Jul 10 00:54:12 2018

[Display Cutout] Support for fullscreen webapps

When a webapp is has the fullscreen display mode set the
fullscreen API is disabled and the activity is in an
"immersive" mode. We should tell WebContents when this
happens so we can support display cutouts in this mode.

BUG= 859241 

Change-Id: I4ce0a647180aa72f2eb5361ad8335956ecb383a2
Reviewed-on: https://chromium-review.googlesource.com/1121537
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573568}
[modify] https://crrev.com/bda2c4df785721b35cdf789f89d6a3291a97a889/chrome/android/java_sources.gni
[modify] https://crrev.com/bda2c4df785721b35cdf789f89d6a3291a97a889/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTest.java
[modify] https://crrev.com/bda2c4df785721b35cdf789f89d6a3291a97a889/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTestRule.java
[add] https://crrev.com/bda2c4df785721b35cdf789f89d6a3291a97a889/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/WebappDisplayCutoutTest.java
[add] https://crrev.com/bda2c4df785721b35cdf789f89d6a3291a97a889/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/WebappDisplayCutoutTestRule.java
[modify] https://crrev.com/bda2c4df785721b35cdf789f89d6a3291a97a889/content/browser/display_cutout_browsertest.cc
[modify] https://crrev.com/bda2c4df785721b35cdf789f89d6a3291a97a889/content/browser/web_contents/web_contents_impl.cc

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05a2ce154e311843ac6301b365a5161695a68dc5

commit 05a2ce154e311843ac6301b365a5161695a68dc5
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Jul 18 17:49:27 2018

[Display Cutout] Remove support for standalone

It looks like standalone apps will still show the
system UI (and should) so they will be blocked
by the Android OS from extending into the display
cutout.

Therefore, we should not give them default control
of the cutout

BUG= 859241 

Change-Id: Ie26d41fe983c1f45e4177676a3f936a03ca3a07c
Reviewed-on: https://chromium-review.googlesource.com/1134080
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576126}
[modify] https://crrev.com/05a2ce154e311843ac6301b365a5161695a68dc5/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/WebappDisplayCutoutTest.java
[modify] https://crrev.com/05a2ce154e311843ac6301b365a5161695a68dc5/content/browser/display_cutout/display_cutout_browsertest.cc
[modify] https://crrev.com/05a2ce154e311843ac6301b365a5161695a68dc5/content/browser/display_cutout/display_cutout_host_impl.cc

Sign in to add a comment