New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859239 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Make a developer switch for enabling/disabling newblue

Project Member Reported by mcchou@chromium.org, Jun 29 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2f85deec0f7bcc9a2064932b928892e8f459bb35

commit 2f85deec0f7bcc9a2064932b928892e8f459bb35
Author: Miao-chen Chou <mcchou@chromium.org>
Date: Mon Jul 16 23:31:56 2018

crosh: Add command for writting a persistent file for Newblue preference

This add a new command, newblue, for setting the preference of
enabling/disabling the use of Newblue Bluetooth stack.

BUG=chromium:859239
TEST=run newblue command with enable/disable and confirm that the
/var/lib/bluetooth/newblue file is added/removed
CQ-DEPEND=CL:1130837

Change-Id: I7b19bdba3ea93c608eb8cdfc941e3c3d16e9fde6
Reviewed-on: https://chromium-review.googlesource.com/1121542
Commit-Ready: Miao-chen Chou <mcchou@chromium.org>
Tested-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2f85deec0f7bcc9a2064932b928892e8f459bb35/crosh/crosh

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16

Labels: merge-merged-chromeos-5.44
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/bluez/+/fbe42c38e5fcd006315ae7828178def16113ceb3

commit fbe42c38e5fcd006315ae7828178def16113ceb3
Author: Miao-chen Chou <mcchou@chromium.org>
Date: Mon Jul 16 23:31:55 2018

CHROMIUM: Add experimental interface for Newblue configuration

This adds a new interface, org.chromium.Experimental to host the methods
or properties where Chromium OS developers can make use of. This adds
a method, SetNewblueEnabled, to allow the preference of
enabling/disabling Newblue stack for the next boot to be memorized.

BUG=chromium:859239
TEST=run dbus-send --system --type=method_call --print-reply --dest=org.bluez \
     /org/bluez org.chromium.BluetoothExperimental.SetNewblueEnabled \
     "boolean:true" and verify that 1 is written to the newblue file
     run dbus-send --system --type=method_call --print-reply --dest=org.bluez \
     /org/bluez org.chromium.BluetoothExperimental.SetNewblueEnabled \
     "boolean:false" and verify that 0 is written to the newblue file

Change-Id: Iaf3bffe8a0b3df77c722a618474062cf89de8fcd
Reviewed-on: https://chromium-review.googlesource.com/1130837
Commit-Ready: Miao-chen Chou <mcchou@chromium.org>
Tested-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/fbe42c38e5fcd006315ae7828178def16113ceb3/plugins/chromium.c
[modify] https://crrev.com/fbe42c38e5fcd006315ae7828178def16113ceb3/doc/chromium-api.txt

Cc: shijinabraham@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/dcd2b2a224364091d601dd04e6a8945bb37b4831

commit dcd2b2a224364091d601dd04e6a8945bb37b4831
Author: Dmitry Grinberg <dmitrygr@google.com>
Date: Tue Jan 08 03:40:49 2019

CHROMIUM: Bluetooth: Enable BLuetooth LE splitter

With this change, BT splitter can be used and newblue can be run. By
default the functionality of the splitter is disabled (CL:1352383) and
users can enable it by using the crosh command (CL:1121542).

BUG=chromium:859239,chromium:909045
TEST=With this built on minnie, enable and disable newblue and check
that splitter is indeed enabled and disabled. Check that by default
(splitter disabled) Bluetooth works normally.
CQ-DEPEND=CL:1378961

Signed-off-by: Sonny Sasaka <sonnysasaka@chromium.org>
Change-Id: I3a142f746471db1d022b673b5418032ae4db5fa8
Reviewed-on: https://chromium-review.googlesource.com/736685
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Dmitry Grinberg <dmitrygr@google.com>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/dcd2b2a224364091d601dd04e6a8945bb37b4831/chromeos/config/armel/chromiumos-rockchip.flavour.config

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dd79eaa937b203f8e49a5e764ca4a1300b8b3f05

commit dd79eaa937b203f8e49a5e764ca4a1300b8b3f05
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Thu Jan 10 09:32:09 2019

bluetooth: Install newblued upstart script

Now newblued can detect whether LE kernel splitter is enabled or not. As
the current default is that LE kernel splitter not enabled, newblued
will enter idle mode so this won't cause any behavior change.

BUG=chromium:859239
TEST=emerge-$BOARD bluetooth, reboot, check that newblued is
automatically started and it enters idle mode.

Change-Id: Ica680478f7f4cc2d03c0d4bd8995e2b7d52ae79e
Reviewed-on: https://chromium-review.googlesource.com/1401249
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Qiyu Hu <qiyuh@google.com>

[modify] https://crrev.com/dd79eaa937b203f8e49a5e764ca4a1300b8b3f05/chromeos-base/bluetooth/bluetooth-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b3a72ca29fcbd6d6041d73a7947f1cfc88fea38f

commit b3a72ca29fcbd6d6041d73a7947f1cfc88fea38f
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Tue Jan 15 19:52:42 2019

Revert "bluetooth: Install newblued upstart script"

This reverts commit dd79eaa937b203f8e49a5e764ca4a1300b8b3f05.

Reason for revert: Crashing for Jetstream.

Original change's description:
> bluetooth: Install newblued upstart script
>
> Now newblued can detect whether LE kernel splitter is enabled or not. As
> the current default is that LE kernel splitter not enabled, newblued
> will enter idle mode so this won't cause any behavior change.
>
> BUG=chromium:859239
> TEST=emerge-$BOARD bluetooth, reboot, check that newblued is
> automatically started and it enters idle mode.
>
> Change-Id: Ica680478f7f4cc2d03c0d4bd8995e2b7d52ae79e
> Reviewed-on: https://chromium-review.googlesource.com/1401249
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
> Reviewed-by: Qiyu Hu <qiyuh@google.com>

Bug: chromium:859239
Change-Id: I9ce338fc26f7341564d09a458ace959fcce64b33
Reviewed-on: https://chromium-review.googlesource.com/1409822
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>

[modify] https://crrev.com/b3a72ca29fcbd6d6041d73a7947f1cfc88fea38f/chromeos-base/bluetooth/bluetooth-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 20 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5a7fdca6ca3b8ce5953be84b769cae01e7f0690a

commit 5a7fdca6ca3b8ce5953be84b769cae01e7f0690a
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Sun Jan 20 11:16:50 2019

bluetooth: Install newblued upstart script

Now newblued can detect whether LE kernel splitter is enabled or not. As
the current default is that LE kernel splitter not enabled, newblued
will enter idle mode so this won't cause any behavior change.

This is a reland of CL:1409822 as the Jetstream issue has been fixed by
CL:1417051.

BUG=chromium:859239
TEST=emerge-$BOARD bluetooth, reboot, check that newblued is
automatically started and it enters idle mode.

Change-Id: Ie6f88393e86fe82cc81b24e9dbd3fde3c836de0e
Reviewed-on: https://chromium-review.googlesource.com/1422637
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Dmitry Grinberg <dmitrygr@google.com>

[modify] https://crrev.com/5a7fdca6ca3b8ce5953be84b769cae01e7f0690a/chromeos-base/bluetooth/bluetooth-9999.ebuild

Sign in to add a comment