New issue
Advanced search Search tips

Issue 859238 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"Linux Files" folder stops working after re-installing Crostini

Project Member Reported by avkodipelli@chromium.org, Jun 29 2018

Issue description

Chrome Version: 69.0.3475.0
Chrome OS Version: 10827.0.0
Chrome OS Platform: Eve/Teemo
Network info: Wifi

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Install crostini(Linux)
(2) Check "Linux Files" folder and copy/paste any files
(3) Go to settings and remove crostini(Linux)
(4) After uninstall, Install crostini again
(5) After successful installation, go to "Linux Files"
(6) Try to paste any files

Expected Result:
- Able to paste any files

Actual Result:
- Throwing error as shown in screenshot in feedback report

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
- Always

Feedback report: 85525160412
 
While this issue observed,
- Install gedit from command prompt using sudo apt-get install gedit
- Observe UI icon in menu, open gedit
- Enter some content and save file
- Observe saved file from command prompt as shown in feedback report screenshot
- Open Linux Files folder from file menu and check for saved file
- no file observed(Check feedback report)

Feedback report: 
85525181642
Cc: joelhockey@chromium.org
Summary: "Linux Files" folder stops working after re-installing Crostini (was: Crostini: Unable to paste any file in "Linux Files" folder)
I guess the file manager doesn't know about uninstallation, so it gets stuck with the old keys. Can work around with rebooting/signing out.
Signing out and in doesn't fix the issue. But it is resolved after rebooting the system.
Cc: dgreid@chromium.org
Cc: weifangsun@chromium.org
Owner: joelhockey@chromium.org
Status: Assigned (was: Untriaged)
Owner: dats@chromium.org
I have verified that uninstalling and reinstalling causes errors on version 10879.0.0.

Reponse to #c2.  Filesapp gets keys and hostname from cicerone each time it connects, so I don't believe it would get stuck with old keys.

I believe that the issue is:
When the container is uninstalled, the mount at /media/fuse is not unmounted.

chronos@localhost / $ ll /media/fuse
ls: cannot access '/media/fuse/crostini_85df2af39f3d917452e3f926e641e58dcf9dbd5f_termina_penguin': Input/output error
total 0
drwxr-xr-x. 3 cros-disks cros-disks  60 Jul 16 10:04 .
drwxrwxrwt. 5 root       root       100 Jul 16 10:01 ..
d?????????? ? ?          ?            ?            ? crostini_85df2af39f3d917452e3f926e641e58dcf9dbd5f_termina_penguin

Then once the container is recreated, and we attempt to mount again, I am seeing this in the /var/log/messages which indicates that the system is not creating a new mount, since it believes it already has a mount to the specified remote destination:

2018-07-16T10:26:05.720572+10:00 INFO vm_cicerone[7745]: Startup of container penguin at IP 100.115.92.204 for VM termina completed.
2018-07-16T10:26:05.722379+10:00 INFO vm_concierge[7754]: Received GetContainerSshKeys request
2018-07-16T10:26:05.724068+10:00 WARNING disks[2029]: Path 'sshfs://joelhockey@penguin.termina.linux.test:' is already mounted to '/media/fuse/crostini_85df2af39f3d917452e3f926e641e58dcf9dbd5f_termina_penguin'
2018-07-16T10:26:07.197894+10:00 INFO VM(5)[7744]:  lxd_setup: Started container 'penguin'

If others are reproducing this error, some useful logs are:
tail -f /var/log/messages 
sudo dbus-monitor --system "interface=org.chromium.VmCicerone"

dats@, do we need to change the sshfs mounting to check for existing mounts and unmount them?  Or do we need to trigger the unmount somehow when the container stops or is uninstalled?

I will attempt to verify this issue using same version as original report.

Owner: joelhockey@chromium.org
It's a known problem with the way CrosDisks tracking mounts, but it's not high priority to fix right now as it's trivial to workaround: you can always ask to unmount first and then mounting will succeed. Also I'd say when crostini was uninstalled something should have trigger an unmount anyway.

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f7748fe20707f1e263ea047302ed1fd50f5a7a

commit 92f7748fe20707f1e263ea047302ed1fd50f5a7a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Jul 16 09:54:49 2018

CrOS FilesApp unmount with cros-disks when crostini sshfs container shutdown

In addition to removing the crostini volume with VolumeManager, also
call DiskMountManager::UnmountPath.

Bug:  859238 
Change-Id: I0b773896ed3048f0bc3c62dcb4835aa547438475
Reviewed-on: https://chromium-review.googlesource.com/1137967
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575213}
[modify] https://crrev.com/92f7748fe20707f1e263ea047302ed1fd50f5a7a/chrome/browser/chromeos/file_manager/volume_manager.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on 10895.10.0, 69.0.3497.21 on kevin.

Sign in to add a comment