New issue
Advanced search Search tips

Issue 859230 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in printing::PrintRenderFrameHelper::CreatePreviewDocument

Project Member Reported by ClusterFuzz, Jun 29 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6716463235465216

Fuzzer: lszekeres_pdf_small
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  printing::PrintRenderFrameHelper::CreatePreviewDocument
  printing::PrintRenderFrameHelper::OnFramePreparedForPreviewDocument
  printing::PrintRenderFrameHelper::PrepareFrameForPreviewDocument
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6716463235465216

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 29 2018

Labels: Test-Predator-Auto-Owner
Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/da7dc652f35badf004c0c7e5b7966152fddbf4d3 (Printing: Fix upscale PDF breakage).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: UI>Browser>PrintPreview
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b14cbef8d0bf48d64ef4878c38bafe783c091abc

commit b14cbef8d0bf48d64ef4878c38bafe783c091abc
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jul 13 19:10:42 2018

PrintRenderFrameHelper: Don't let fit to page scaling be undefined

If the preset options contain a zero width or height page size,
computing the fit to page width or height will result in a division
by zero and these values will be undefined. Use 0.0f, indicating
an unknown/unavailable fit to page scaling, in this case.

Bug:  859230 
Change-Id: Ib5b36786da9ba82b1ba1642a5d9ff9c086342fee
Reviewed-on: https://chromium-review.googlesource.com/1135785
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575008}
[modify] https://crrev.com/b14cbef8d0bf48d64ef4878c38bafe783c091abc/components/printing/renderer/print_render_frame_helper.cc

Project Member

Comment 4 by ClusterFuzz, Jul 14

ClusterFuzz has detected this issue as fixed in range 575007:575008.

Detailed report: https://clusterfuzz.com/testcase?key=6716463235465216

Fuzzer: lszekeres_pdf_small
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  printing::PrintRenderFrameHelper::CreatePreviewDocument
  printing::PrintRenderFrameHelper::OnFramePreparedForPreviewDocument
  printing::PrintRenderFrameHelper::PrepareFrameForPreviewDocument
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=575007:575008

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6716463235465216

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Jul 14

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6716463235465216 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment