VrShellNavigationTest#testWebV/XrPresentingTo* broken |
||||
Issue descriptionThe navigation tests for navigating away from a VR presentation are currently broken due to https://chromium.googlesource.com/chromium/src/+/f793e16665dca752ab572ba1852e27049563417f. They are failing this assert https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java?q=vrshellnavigationtest&sq=package:chromium&dr=CSs&l=125 after supposedly navigating, i.e. we're still presenting when we shouldn't be. This appears to be due to a failure to navigate, rather than navigating but remaining in VR.
,
Jun 29 2018
looking
,
Jun 29 2018
,
Jun 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe2358a95eaf5dbe2ac82198009795ff4bf2c33c commit fe2358a95eaf5dbe2ac82198009795ff4bf2c33c Author: Bill Orr <billorr@chromium.org> Date: Sat Jun 30 03:46:52 2018 Fix VrShellNavigationTests These tests were flakily broken by a recent change to introduce a mojo interface where a C++ interface once was. During destruction, there was a race between an async mojo binding error vs. GvrDevice destruction. If GvrDevice is destroyed too early, we don't get the disconnect message and the GvrDelegate is never told that we have exited presentation. The fix is to check whether we are presenting in GvrDevice's destructor, and treat destruction as another signal to stop presentation. TBR=mthiesse,bsheedy Bug: 859217 Change-Id: I0c47da28d4c61ad44839d0b3c1dff1240d2e034d Reviewed-on: https://chromium-review.googlesource.com/1121624 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571756} [modify] https://crrev.com/fe2358a95eaf5dbe2ac82198009795ff4bf2c33c/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/fe2358a95eaf5dbe2ac82198009795ff4bf2c33c/device/vr/android/gvr/gvr_device.h
,
Jun 30 2018
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bsheedy@chromium.org
, Jun 29 2018